Bug 79826 - multimedia/transcode builds without optimization if multimedia/linux-divx4linux is installed
Summary: multimedia/transcode builds without optimization if multimedia/linux-divx4lin...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-12 16:10 UTC by Jonathan Lennox
Modified: 2005-05-04 12:44 UTC (History)
0 users

See Also:

Attachments
file.diff (491 bytes, patch)
2005-04-12 16:10 UTC, Jonathan Lennox 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Lennox 2005-04-12 16:10:30 UTC 
Due to a bug in the port Makefile, if the port multimedia/linux-divx4linux is
installed, the build of the port multimedia/transcode discards the system
CFLAGS, so transcode is built without any optimization flags.

Fix: The following patch fixes it.  This fix might imply that a PORTREVISION
bump is in order; I'm not sure of what policy is on that.

Alternately, as a workaround, uninstall multimedia/linux-divx4linux before
building transcode.
How-To-Repeat: # portinstall multimedia/linux-divx4linux
# cd /usr/ports/multimedia/transcode; make

Observe the arguments to cc, in particular the lack of any -O options.
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2005-04-12 22:14:48 UTC 
Dear maintainer of FreeBSD port multimedia/transcode, please take a look
at

http://www.freebsd.org/cgi/query-pr.cgi?q=79826

Can you take a look at this patch and approve it/reject it/correct it?
I'm not completely convinced it's the right solution.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

The Phase Spider. A spider that never seems quite there.
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2005-04-12 22:14:50 UTC 
State Changed
From-To: open->feedback

Asked maintainer for oppinion
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2005-04-12 22:14:50 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pav

Handle
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2005-05-04 12:44:38 UTC 
State Changed
From-To: feedback->closed

Maintainer timeout; variation on your patch committed, thank you.