Bug 80917 - Update: devel/picprog 1.4 -> 1.7 + adoption
Summary: Update: devel/picprog 1.4 -> 1.7 + adoption
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jean-Yves Lefort
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-12 02:28 UTC by Erik Greenwald
Modified: 2005-05-25 10:24 UTC (History)
1 user (show)

See Also:


Attachments
devel-picprog.patch (3.54 KB, patch)
2005-05-12 02:28 UTC, Erik Greenwald
no flags Details | Diff
devel-picprog.2.patch (3.61 KB, patch)
2005-05-18 17:13 UTC, Erik Greenwald
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Greenwald 2005-05-12 02:28:44 UTC
update of devel/picprog from 1.4 to 1.7, cleanup and simpilification
of the makefile and shtuff, and I'd be happy to adopt this one :)

tested on 5.4 and 6.0 athlons (both hosts listed in 'Environment')
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2005-05-12 02:43:09 UTC
State Changed
From-To: open->feedback

Does not build on 4-x: 

main.cc:35: getopt.h: No such file or directory 
In file included from main.cc:39: 
program.h:34: getopt.h: No such file or directory 
main.cc: In function `int main(int, char **)': 
main.cc:68: elements of array `struct option long_opts[]' have incomplete type 
main.cc:69: `no_argument' undeclared (first use this function) 
main.cc:69: (Each undeclared identifier is reported only once 
main.cc:69: for each function it appears in.) 
main.cc:73: `required_argument' undeclared (first use this function) 
main.cc:86: array size missing in `long_opts' 
main.cc:86: storage size of `long_opts' isn't known 
main.cc:92: confused by earlier errors, bailing out 
*** Error code 1
Comment 2 Erik Greenwald 2005-05-18 17:13:20 UTC
On Thu, May 12, 2005 at 01:44:00AM +0000, Kirill Ponomarew wrote:
> Synopsis: Update:  devel/picprog  1.4 -> 1.7  + adoption
<snip>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=80917

the issue was with CPPFLAGS and LDFLAGS not being honored, so the
getopt_long fu for 4 was being ignored... required a MAKE_ENV clause in
the port makefile and a .cc.o target in the softwares makefile..

Attached is a replacement patch (throw the other patch away). If it's
easier to fetch it, it's also at
http://smluc.org/~erik/devel-picprog.2.patch

Thanks

-- 
        -Erik <erik@smluc.org> [http://math.smsu.edu/~erik]

The opinions expressed by me are not necessarily opinions. In all probability,
they are random rambling, and to be ignored. Failure to ignore may result in
severe boredom or confusion. Shake well before opening. Keep Refrigerated.
Comment 3 Jean-Yves Lefort freebsd_committer freebsd_triage 2005-05-25 09:45:01 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jylefort

Take.
Comment 4 Jean-Yves Lefort freebsd_committer freebsd_triage 2005-05-25 10:21:33 UTC
State Changed
From-To: feedback->closed

Committed, thanks! 

Notes: 
- it still did not build on 4.X (see patch-picport.cc) 
- I have kept do-install, as the vendor Makefile is not ${PREFIX}-clean 
- I have kept the documentation, as it looks quite useful