Bug 81401 - [update] net/balance to 3.22
Summary: [update] net/balance to 3.22
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-23 14:00 UTC by Andrej Zverev
Modified: 2005-05-26 12:47 UTC (History)
0 users

See Also:


Attachments
balance-3.22.diff (1.43 KB, patch)
2005-05-23 14:00 UTC, Andrej Zverev
no flags Details | Diff
balance.diff (1.34 KB, patch)
2005-05-25 08:08 UTC, Andrej Zverev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Zverev 2005-05-23 14:00:21 UTC
	Changes:
	writelock and channelcount patch from Stoyan Genov 
	balance exit codes fix from Chris Wilson 
	/var/run/balance is tried to be autocreated (if not there) 
	close of 0,1,2 on background operation

	If maintainer want, it's possible utilize pkg-plist and safe inodes :)

Fix: Use this patch
	Thank you
Comment 1 Sergey Matveychuk freebsd_committer freebsd_triage 2005-05-24 16:01:15 UTC
Dear maintainer!

Please, take the PR into account.

--
Sem.
Comment 2 Joseph Scott 2005-05-24 16:26:14 UTC
On May 24, 2005, at 8:01 AM, Sergey Matveychuk wrote:

> Dear maintainer!
>
> Please, take the PR into account.

Again, CC'ing me on the original PR would make things a bit easier.

This PR looks fine, although I've tested it.  If this builds fine for  
you then I'm okay with this patch.

I'd be fine with updating the port to use pkg-plist, although I'm not  
sure what you mean by "safe inodes".

Thank you again for taking time to help.

--
Joseph Scott
URL: http://joseph.randomnetworks.com/
Email: joseph@randomnetworks.com
Comment 3 Sergey Matveychuk freebsd_committer freebsd_triage 2005-05-24 16:38:52 UTC
Joseph Scott wrote:
> I'd be fine with updating the port to use pkg-plist, although I'm not  

I think the submitter meant: to get rid of pkg-plist to save an inode ;-)

--
Sem.
Comment 4 Joseph Scott 2005-05-24 16:42:53 UTC
On May 24, 2005, at 8:38 AM, Sergey Matveychuk wrote:

> Joseph Scott wrote:
>
>> I'd be fine with updating the port to use pkg-plist, although I'm not
>>
>
> I think the submitter meant: to get rid of pkg-plist to save an  
> inode ;-)


Ahhh, save an inode.  Yes, that does make sense.


--
Joseph Scott
URL: http://joseph.randomnetworks.com/
Email: joseph@randomnetworks.com
Comment 5 Sergey Matveychuk freebsd_committer freebsd_triage 2005-05-24 17:12:16 UTC
> -+CFLAGS+=-Wall
> ++CFLAGS=-Wall

What is the reason to stop respecting CFLAGS?

--
Sem.
Comment 6 Andrej Zverev 2005-05-25 08:08:28 UTC
Where is no reason for this, i just miss it, sorry.
Here complete patch again, if Joseph agree with it.
Comment 7 Joseph Scott 2005-05-25 16:19:56 UTC
On May 25, 2005, at 12:08 AM, Andrej Zverev wrote:

> Where is no reason for this, i just miss it, sorry.
> Here complete patch again, if Joseph agree with it.
>
>
> <balance.diff>
>


Although I haven't tried it, this diff looks good.  If it builds for  
you then I'm fine with it.

--
Joseph Scott
URL: http://joseph.randomnetworks.com/
Email: joseph@randomnetworks.com
Comment 8 Sergey Matveychuk freebsd_committer freebsd_triage 2005-05-26 12:47:47 UTC
State Changed
From-To: open->closed

Committed, thanks!