Bug 82768 - mail/postfix -- certain manpages are broken
Summary: mail/postfix -- certain manpages are broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jean-Yves Lefort
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-29 09:30 UTC by Jeremy Chadwick
Modified: 2005-07-06 16:50 UTC (History)
0 users

See Also:


Attachments
smime.p7s (2.42 KB, application/pkcs7-signature)
2005-07-06 16:50 UTC, Vick Khera
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Chadwick 2005-06-29 09:30:21 UTC
	There's a slew of manpages included with postfix 2.2.4 which are broken.  Here's
	the list:

	man1/mailq.1
	man1/newaliases.1
	man5/body_checks.5
	man8/defer.8
	man8/trace.8

	These manpages use nothing more than a disgusting hack -- that doesn't work -- to
	refer to other manpage files.  They attempt to use the ".so" macro, which is NOT for
	this purpose, and doesn't work with compressed manpage environments.  The ".so"
	macro should be used to refer to other groff macro files during translation, not
	as a troff man command.

	The port maintainer may want to discuss all of this with Wietse, as this is something
	that's downright broken in the core of postfix's source, and isn't "BSD-specific".
	If the maintainer doesn't want to do this, I can do it if they so request.

Fix: 

I tried making a patch for man/Makefile.in, but it doesn't seem to work.  I think
	the reason is that the FreeBSD port isn't actually rebuilding the manpages when
	building postfix; it's using the ones that're pre-generated which contain the
	".so" macro.

	My fix was to replace the echo statements with "ln -s <original> $@" instead,
	so that when the installer goes to copy the manpage to the actual installation
	directory, it copies the content of what the symlink points to.

	There's a couple ways to solve this whole ordeal in ports, but I really don't
	know how we want to do it which would be ~99% clean...
How-To-Repeat: 	Install postfix, then try to view the included-with-postfix mailq manpage (you can
	view this by doing "zcat /usr/local/man/man1/mailq.1.gz | nroff -Tman -man | less").
	You'll find that there's nothing but pure blank output, because the manpage is
	trying to access /usr/local/man/man1/sendmail.1 which doesn't exist.
Comment 1 Jean-Yves Lefort freebsd_committer freebsd_triage 2005-06-29 14:38:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jylefort

Take.
Comment 2 Jean-Yves Lefort freebsd_committer freebsd_triage 2005-06-29 14:47:28 UTC
Maintainer: do you approve the following patch?

diff -ruN /usr/ports/mail/postfix/Makefile ./Makefile
--- /usr/ports/mail/postfix/Makefile	Thu Jun 23 05:58:55 2005
+++ ./Makefile	Wed Jun 29 15:37:49 2005
@@ -16,7 +16,7 @@
 
 PORTNAME=	postfix
 PORTVERSION=	2.2.4
-PORTREVISION=	0
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	mail ipv6
 MASTER_SITES=	ftp://ftp.porcupine.org/mirrors/postfix-release/official/ \
@@ -37,18 +37,24 @@
 USE_SUBMAKE=	yes
 USE_REINPLACE=	yes
 
-MAN1=	mailq.1 newaliases.1 postalias.1 postcat.1 postconf.1 postdrop.1 postfix.1 \
-	postkick.1 postlock.1 postlog.1 postmap.1 postqueue.1 postsuper.1 sendmail.1
+MAN1=	postalias.1 postcat.1 postconf.1 postdrop.1 postfix.1 postkick.1 \
+	postlock.1 postlog.1 postmap.1 postqueue.1 postsuper.1 sendmail.1
 
-MAN5=	access.5 aliases.5 body_checks.5 canonical.5 cidr_table.5 generic.5 \
+MAN5=	access.5 aliases.5 canonical.5 cidr_table.5 generic.5 \
 	header_checks.5 ldap_table.5 master.5 mysql_table.5 nisplus_table.5 \
 	pcre_table.5 pgsql_table.5 postconf.5 regexp_table.5 relocated.5 \
 	transport.5 virtual.5
 
-MAN8=	anvil.8 bounce.8 cleanup.8 defer.8 discard.8 error.8 flush.8 lmtp.8 \
+MAN8=	anvil.8 bounce.8 cleanup.8 discard.8 error.8 flush.8 lmtp.8 \
 	local.8 master.8 oqmgr.8 pickup.8 pipe.8 proxymap.8 qmgr.8 qmqpd.8 \
-	scache.8 showq.8 smtp.8 smtpd.8 spawn.8 tlsmgr.8 trace.8 trivial-rewrite.8 \
+	scache.8 showq.8 smtp.8 smtpd.8 spawn.8 tlsmgr.8 trivial-rewrite.8 \
 	verify.8 virtual.8
+
+MLINKS=	sendmail.1 mailq.1 \
+	sendmail.1 newaliases.1 \
+	header_checks.5 body_checks.5 \
+	bounce.8 defer.8 \
+	bounce.8 trace.8
 
 CONF1=	access aliases canonical generic header_checks main.cf master.cf \
 	relocated transport virtual


-- 
Jean-Yves Lefort

jylefort@FreeBSD.org
http://lefort.be.eu.org/
Comment 3 Jean-Yves Lefort freebsd_committer freebsd_triage 2005-06-29 14:53:03 UTC
State Changed
From-To: open->feedback

Asked maintainer for approval.
Comment 4 Jean-Yves Lefort freebsd_committer freebsd_triage 2005-07-05 23:56:42 UTC
State Changed
From-To: feedback->closed

Superseded by ports/83032.
Comment 5 Vick Khera 2005-07-06 16:50:03 UTC
On Jun 29, 2005, at 9:47 AM, Jean-Yves Lefort wrote:

> Maintainer: do you approve the following patch?

looks ok to me.  however, there is another patch to the postfix port  
that supercedes (include) this one.  please commit that: PR 83032