Bug 83606 - [NEW PORT] mail/squirrelmail-compatibility-plugin: Compatibility API Plugin for SquirrelMail
Summary: [NEW PORT] mail/squirrelmail-compatibility-plugin: Compatibility API Plugin f...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-17 14:40 UTC by alexander
Modified: 2005-07-22 23:33 UTC (History)
0 users

See Also:


Attachments
sqm_compat.sh (7.83 KB, text/plain)
2005-07-17 14:40 UTC, alexander
no flags Details
sqm_compat.sh.uu (9.45 KB, application/uue; x-mac-type="0"; x-mac-creator="0")
2005-07-22 19:44 UTC, alexander
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description alexander 2005-07-17 14:40:07 UTC
This plugin for the SquirrelMail WebMailer is the first of several ports I have written for some squirrelmail plugins. If this one is OK, I will send in the others (they are fairly similar to this one).
I am not sure if the name of this port is correct, portlint complains about the dashes, but other ports (eg multimedia/xmms-status-plugin) do the same, so I'll just mimic their behaviour.

Although it should run on any Version of FreeBSD, I have only tested with 4.11-STABLE and a generic 5.3-RELEASE. This port requires SquirrelMail 1.4.5!

About the Plugin: It provides a standard API for other plugins and has no functionality in and of itself.

How-To-Repeat: N/A
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2005-07-19 17:23:51 UTC
State Changed
From-To: open->feedback

Several issues with your port: 

1) don't use @cwd in pkg-plist. instead, write the entries like 
%%SQUIRRELDIR%%/plugins/compatibility/includes ... 

2) will the patch command in pkg-plist create .orig file? If yes, that file 
must be cleaned up 

3) you're removing directories in pkg-plist which have no files in them - 
these directories will not get created when adding package. add some 
@exec mkdir -p %D/%%SQUIRRELDIR%%/plugins/compatibility/includes/1.4.1 
lines to the plist. 

4) PLIST_SUB is incorrect in Makefile, you must assign the value of  
SQUIRRELDIR without the ${PREFIX} part there, so, what about 

.if !defined(WITHOUT_WWWDIR) 
SQUIRRELDIR?=	${PREFIX}/www/squirrelmail 
PLIST_SUB+=	SQUIRRELDIR=www/squirrelmail 
.else 
SQUIRRELDIR?=	${PREFIX}/squirrelmail 
PLIST_SUB+=	SQUIRRELDIR=squirrelmail 
.endif 

5) Please indent all variables in Makefile to two tabs, now your indentation 
varies from 2 to 4 tabs. 

Please fix those issues and resubmit the port. 


Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2005-07-19 17:23:51 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Handle
Comment 3 alexander 2005-07-22 19:44:55 UTC
Hi

Thanks for your advice. This is the first port I have made, so I'm glad 
about your feedback. I have fixed the problems you mentioned and hope 
everything is OK now :-)

Thanks,
Alexander Wittig
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2005-07-22 23:33:05 UTC
State Changed
From-To: feedback->closed

New port added, thank you!