Bug 84019 - net/ntop doesn't build with rrdtool 1.2.10
Summary: net/ntop doesn't build with rrdtool 1.2.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Clement Laforet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-24 23:30 UTC by Bryan Fullerton
Modified: 2005-08-01 11:15 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Fullerton 2005-07-24 23:30:06 UTC 
% sudo portinstall ntop
--->  Installing 'ntop-3.1_1' from a port (net/ntop)
--->  Building '/usr/ports/net/ntop'
[...]
(cd .libs && rm -f libpdaPlugin.la && ln -s ../libpdaPlugin.la libpdaPlugin.la)
if /bin/sh ../libtool --mode=compile cc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I/usr/local/include -I/usr/include  -I../myrrd  -DFREEBSD -I/usr/local/include -I/usr/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/include -I/usr/include  -g -O -pipe  -I/usr/local/include -g -Wshadow -Wpointer-arith -Wmissing-prototypes -Wmissing-declarations -Wnested-externs  -fPIC -MT rrdPlugin.lo -MD -MP -MF ".deps/rrdPlugin.Tpo" -c -o rrdPlugin.lo rrdPlugin.c; \
then mv -f ".deps/rrdPlugin.Tpo" ".deps/rrdPlugin.Plo"; else rm -f ".deps/rrdPlugin.Tpo"; exit 1; fi
rm -f .libs/rrdPlugin.lo
cc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I/usr/local/include -I/usr/include -I../myrrd -DFREEBSD -I/usr/local/include -I/usr/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/include -I/usr/include -g -O -pipe -I/usr/local/include -g -Wshadow -Wpointer-arith -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fPIC -MT rrdPlugin.lo -MD -MP -MF .deps/rrdPlugin.Tpo -c rrdPlugin.c  -fPIC -DPIC -o .libs/rrdPlugin.lo
rrdPlugin.c: In function `graphCounter':
rrdPlugin.c:583: error: too few arguments to function `rrd_graph'
rrdPlugin.c: In function `netflowSummary':
rrdPlugin.c:728: error: too few arguments to function `rrd_graph'
rrdPlugin.c: In function `graphSummary':
rrdPlugin.c:926: error: too few arguments to function `rrd_graph'
gmake[3]: *** [rrdPlugin.lo] Error 1
gmake[3]: Leaving directory `/export/ports/net/ntop/work/ntop/plugins'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/export/ports/net/ntop/work/ntop/plugins'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/export/ports/net/ntop/work/ntop'
gmake: *** [all] Error 2
*** Error code 2

Stop in /export/ports/net/ntop.
Comment 1 piotr 2005-07-25 00:54:46 UTC 
hi

I have exact the same problem and get the same errors.

to clean a port, reinstall or upgrade ntop or rrdtool doesn't help.

I've done:
# portupgrade -a -N -vu -R net/ntop
and 
# portupgrade -a -N -vu -r net/ntop

but still get errors !

I've reported this problem to the port maintainer,
but didn't get any answer.
This is a little strange.

under freeBSD 5.2.1 on the same hardware I didn't have any problems.

kind regards
piotr
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2005-07-25 02:16:10 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->clement

Over to maintainer.
Comment 3 Michael Nottebrock freebsd_committer freebsd_triage 2005-07-26 14:39:03 UTC 
Fix:


--- ntop.h.orig	Tue Jul 26 03:39:16 2005
+++ ntop.h	Tue Jul 26 03:39:29 2005
@@ -447,7 +447,7 @@
 #endif
 
 #ifndef EMBEDDED
-#include "rrd.h"
+#include "myrrd/rrd.h"
 #endif
 
 #ifdef HAVE_GETOPT_H
Comment 4 Clement Laforet freebsd_committer freebsd_triage 2005-08-01 11:14:14 UTC 
State Changed
From-To: open->closed

A fix has been committed, thanks for reporting this!