Xaw3d is maintained by D J Hawkey Jr since April 2003 (see http://www.visi.com/~hawkeyd/xaw3d.html). The attached patch fixes the port to use the latest official version an to use an additional patch provided by Stefan Monnier that allows the user to enable or disable arrows in sclollbars at runtime. Fix: Apply the attached patch. How-To-Repeat: N.A.
Responsible Changed From-To: freebsd-ports-bugs->lesi Take.
Hi, Few nits: You seem to have missed a couple of files that get installed by new version: include/X11/Xaw3d/Tip.h include/X11/Xaw3d/TipP.h include/X11/Xaw3d/Xaw3dP.h They should be added to pkg-plist file. I gather from patch that file files/patch-aa is to be removed, am I correct. You might want to use option -N to diff(1) so such files are present in resulting patch (see also Upgrading chapter of Porter's Handbook). Another thing is that homepage mentions potential problems with xfig (graphics/xfig), any chance you tried if xfig works after this upgrade? As this port has no maintainer, have you perhaps considered taking maintainership of it? And finally, just in case you don't know - there is a ports freeze at the moment, so it might be a while until this upgrade can be committed.
On Tue, 16 Aug 2005, Dejan Lesjak wrote: > Few nits: You seem to have missed a couple of files that get installed by new > version: > include/X11/Xaw3d/Tip.h > include/X11/Xaw3d/TipP.h > include/X11/Xaw3d/Xaw3dP.h > They should be added to pkg-plist file. > I gather from patch that file files/patch-aa is to be removed, am I correct. > You might want to use option -N to diff(1) so such files are present in > resulting patch (see also Upgrading chapter of Porter's Handbook). Thanks for the tips. I will try to make a better patch. > Another thing is that homepage mentions potential problems with xfig > (graphics/xfig), any chance you tried if xfig works after this upgrade? I don't know because I use XFig without Xaw3D, but I can verify that. > As this port has no maintainer, have you perhaps considered taking > maintainership of it? Perhaps, but I can't take such responsability now because I'm involved with other things. > And finally, just in case you don't know - there is a ports freeze at the > moment, so it might be a while until this upgrade can be committed. I'm aware of the ports freeze, but I needed to send all my patches ASAP because I will loose this mail account soon (please send follow-ups to casantos at unixforge dot org). -- Casantos
On Saturday 20 of August 2005 00:57, Carlos A M dos Santos wrote: > On Tue, 16 Aug 2005, Dejan Lesjak wrote: > > Few nits: You seem to have missed a couple of files that get installed by > > new version: > > include/X11/Xaw3d/Tip.h > > include/X11/Xaw3d/TipP.h > > include/X11/Xaw3d/Xaw3dP.h > > They should be added to pkg-plist file. > > I gather from patch that file files/patch-aa is to be removed, am I > > correct. You might want to use option -N to diff(1) so such files are > > present in resulting patch (see also Upgrading chapter of Porter's > > Handbook). > > Thanks for the tips. I will try to make a better patch. There's no need for new patch for this - I already made above changes when testing build, so you just need to confirm if I'm right or yell if I commit a change that's not correct :) You can use the tips and Handbook for future patches though. > > Another thing is that homepage mentions potential problems with xfig > > (graphics/xfig), any chance you tried if xfig works after this upgrade? > > I don't know because I use XFig without Xaw3D, but I can verify that. That would be great so we can be prepared to patch XFig also. I'm sure we'll hear sooner or later if something breaks in any case though. > > As this port has no maintainer, have you perhaps considered taking > > maintainership of it? > > Perhaps, but I can't take such responsability now because I'm involved > with other things. > > > And finally, just in case you don't know - there is a ports freeze at the > > moment, so it might be a while until this upgrade can be committed. > > I'm aware of the ports freeze, but I needed to send all my patches ASAP > because I will loose this mail account soon (please send follow-ups to > casantos at unixforge dot org). Great, thanks for following up! Dejan
State Changed From-To: open->closed Committed, thanks!