Bug 85723 - [patch] Remove module dependent on X libraries
Summary: [patch] Remove module dependent on X libraries
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sam Lawrance
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-05 03:30 UTC by Jakub Rehor
Modified: 2005-09-06 04:33 UTC (History)
0 users

See Also:

Attachments
clisp.diff (970 bytes, patch)
2005-09-05 03:30 UTC, Jakub Rehor 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Rehor 2005-09-05 03:30:15 UTC 
Remove module CLX which requires presence of X libraries and causes the port
to fail to build on machines without X.
Comment 1 Sam Lawrance freebsd_committer freebsd_triage 2005-09-05 04:01:05 UTC 
On Sun, 2005-09-04 at 22:24 -0400, jakub@rehor.net wrote:
> Remove module CLX which requires presence of X libraries and causes the port
> to fail to build on machines without X.

Why don't you make it an option which can be turned off if necessary?
It would be simple to do.
Comment 2 Sam Lawrance freebsd_committer freebsd_triage 2005-09-05 04:01:58 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->lawrance

Take
Comment 3 Sam Lawrance freebsd_committer freebsd_triage 2005-09-05 16:04:47 UTC 
State Changed
From-To: open->feedback

Asked for feedback
Comment 4 Jakub Rehor 2005-09-05 19:36:06 UTC 
You make a good point; it should be an option. There are actually a 
number of modules that can be compiled; I will look into setting up an 
interactive dialog that asks the user to specifiy which modules to 
include. I will also specify a reasonable default set of modules for 
batch compilation.

CLX module should not be included in the default set: some users may run 
Clisp on Web servers without X installed and do not need CLX. Those 
users are currently unable to compile the port.

Until I finish the interactive setup, can you remove the CLX option so 
that non-X installations can upgrade their Clisp?
Comment 5 Sam Lawrance freebsd_committer freebsd_triage 2005-09-06 04:33:19 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!