Bug 86032 - www/jakarta-tomcat55: bug in RCng startup script ${PREFIX}/etc/rc.d/jakarta-tomcat55.sh
Summary: www/jakarta-tomcat55: bug in RCng startup script ${PREFIX}/etc/rc.d/jakarta-t...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Herve Quiroz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-12 23:10 UTC by Julio C. Perera R.
Modified: 2005-09-14 13:58 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julio C. Perera R. 2005-09-12 23:10:03 UTC 
Call to: load_rc_config "${name}" is made almost at the end of the file, so custom variables especified in /etc/rc.conf have no effect on most of the script.

Fix: 

Simply move the line saying: load_rc_config "${name}"
above the variables processing directives, a good place is after the line saying: rcvar=`set_rcvar`
How-To-Repeat: Add any custom variable for tomcat55 to your /etc/rc.conf, ex.: jakarta_tomcat55_java_opts="-Xms128m -Xmx128m -Djava.awt.headless=true"
Go and check it doesn't have any effect on the call to JVM
Comment 1 Herve Quiroz freebsd_committer freebsd_triage 2005-09-13 20:17:25 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->hq

I'll handle this.
Comment 2 Herve Quiroz freebsd_committer freebsd_triage 2005-09-14 13:58:04 UTC 
State Changed
From-To: open->closed

Patch commited. 

Thanks for your contribution!