Gerris is an Open Source Free Software library for the solution of the partial differential equations describing fluid flow. The source code is available free of charge under the Free Software GPL license. Gerris is supported by NIWA (National Institute of Water and Atmospheric research) and by the Marsden Fund of the Royal Society of New Zealand. The code is written entirely in C and uses both the GLib Library and the GTS Library for geometrical functions and object-oriented programming.
Responsible Changed From-To: freebsd-ports-bugs->thierry Take it.
State Changed From-To: open->feedback Hello, This port is very interesting, but I have some remarks. 1) There is a new policy, and it is no more allowed to commit a port with the MAINTAINER field set to "ports@FreeBSD.org"; would you accept to maintain it, at least for the first package builds on the cluster? 2) IMHO "science" would be a righter primary CATEGORIES (math could be a second category); what do you think? 3) Could you please review the following patch? --- gerris.diff begins here --- diff -urN math/gerris.orig/Makefile math/gerris/Makefile --- math/gerris.orig/Makefile Tue Sep 20 21:23:53 2005 +++ math/gerris/Makefile Tue Sep 20 23:24:43 2005 @@ -6,24 +6,57 @@ # $FreeBSD$ # -PORTNAME= gerris -PORTVERSION= 0.6.0 -CATEGORIES= math -MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} -MASTER_SITE_SUBDIR= gfs - -PATCH_SITES= ${MASTER_SITE_SOURCEFORGE}gfs/ - http://members.aon.at/odunkl/downloads/patches/ -PATCHFILES= gerris-0.6-patch-1.gz - gerris-0.6-patch-2.gz -PATCH_DIST_STRIP= -p1 - -MAINTAINER= ports@FreeBSD.org -COMMENT= A scientific CFD simulator +PORTNAME= gerris +PORTVERSION= 0.6.0 +CATEGORIES= math +MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} +MASTER_SITE_SUBDIR= gfs -LIB_DEPENDS= gts.3:${PORTSDIR}/graphics/gts +PATCH_SITES= ${MASTER_SITE_SOURCEFORGE}gfs/ + http://members.aon.at/odunkl/downloads/patches/ +PATCHFILES= gerris-0.6-patch-1.gz + gerris-0.6-patch-2.gz +PATCH_DIST_STRIP= -p1 -USE_GMAKE= yes -GNU_CONFIGURE= yes +MAINTAINER= ports@FreeBSD.org +COMMENT= A scientific CFD simulator -.include <bsd.port.mk> +LIB_DEPENDS= gts.3:${PORTSDIR}/graphics/gts + +.if !defined(WITHOUT_DX) +BUILD_DEPENDS+= dx:${PORTSDIR}/graphics/opendx +RUN_DEPENDS+= dx:${PORTSDIR}/graphics/opendx +.else +CONFIGURE_ARGS+= --disable-dx +.endif + +USE_GMAKE= yes +USE_AUTOTOOLS= libtool:15 +CONFIGURE_TARGET= --build=${MACHINE_ARCH}-portbld-freebsd${OSREL} +INSTALLS_SHLIB= yes +USE_GNOME= pkgconfig +USE_GETOPT_LONG= yes +USE_REINPLACE= yes + +MPIDIR= ${LOCALBASE}/mpich + +.include <bsd.port.pre.mk> + +# TODO: add support for MPI +#.if exists(${MPIDIR}/bin/mpiCC) +#WITH_MPI= yes +#.endif +#.if defined(WITH_MPI) +#PKGNAMESUFFIX+= -mpich +#BUILD_DEPENDS+= ${MPIDIR}/bin/mpiCC:${PORTSDIR}/net/mpich +#CONFIGURE_ARGS+= --with-mpicc=${MPIDIR}/bin/mpiCC +#MAKE_ARGS= LIBTOOL="${LIBTOOL} --tag=CC" +#.else +CONFIGURE_ARGS+= --disable-mpi +#.endif + +post-patch: + @${REINPLACE_CMD} -e 's|(libdir)/pkgconfig|(prefix)/libdata/pkgconfig|' + ${WRKSRC}/src/Makefile.in + +.include <bsd.port.post.mk> diff -urN math/gerris.orig/pkg-plist math/gerris/pkg-plist --- math/gerris.orig/pkg-plist Tue Sep 20 21:23:53 2005 +++ math/gerris/pkg-plist Wed Sep 21 00:06:00 2005 @@ -43,44 +43,33 @@ lib/gerris/libdx2D-0.6.so lib/gerris/libdx2D-0.6.so.1 lib/gerris/libdx2D.a -lib/gerris/libdx2D.la lib/gerris/libdx2D.so lib/gerris/libdx3D-0.6.so lib/gerris/libdx3D-0.6.so.1 lib/gerris/libdx3D.a -lib/gerris/libdx3D.la lib/gerris/libdx3D.so lib/gerris/libperiodic_flow2D.a -lib/gerris/libperiodic_flow2D.la lib/gerris/libperiodic_flow2D.so lib/gerris/libperiodic_flow2D.so.0 lib/gerris/libtesting2D.a -lib/gerris/libtesting2D.la lib/gerris/libtesting2D.so lib/gerris/libtesting2D.so.0 lib/gerris/libvorticity_spectrum2D.a -lib/gerris/libvorticity_spectrum2D.la lib/gerris/libvorticity_spectrum2D.so lib/gerris/libvorticity_spectrum2D.so.0 lib/libgfs2D-0.6.so lib/libgfs2D-0.6.so.1 lib/libgfs2D.a -lib/libgfs2D.la lib/libgfs2D.so lib/libgfs2D3-0.6.so lib/libgfs2D3-0.6.so.1 lib/libgfs2D3.a -lib/libgfs2D3.la lib/libgfs2D3.so lib/libgfs3D-0.6.so lib/libgfs3D-0.6.so.1 lib/libgfs3D.a -lib/libgfs3D.la lib/libgfs3D.so -lib/pkgconfig/gerris2D.pc -lib/pkgconfig/gerris3D.pc -share/nls/POSIX -share/nls/en_US.US-ASCII -@dirrm lib/pkgconfig +libdata/pkgconfig/gerris2D.pc +libdata/pkgconfig/gerris3D.pc @dirrm lib/gerris @dirrm include/gerris --- gerris.diff ends here --- This patch addresses several points: - it replaces spaces by tabs, with some minor changes to make portlint happy; - this port tries to use OpenDX, then I have added a dependence. Remark: I have set it by default, like in the original program, but you can revert WITHOUT_DX by WITH_DX or use options if you prefer; - it uses libtool; - it could use mpich, then I have prepared this dependence. Remark: it is still commented out, as a reminder, and is not required for the initial submission; - fix pkgconfig. Regards,
State Changed From-To: feedback->closed New port added, thanks!