Bug 86430 - [patch] mail/thunderbird does not build with the correct esound library
Summary: [patch] mail/thunderbird does not build with the correct esound library
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-21 22:50 UTC by Mark Hobden
Modified: 2005-09-23 21:44 UTC (History)
0 users

See Also:


Attachments
thunderbird-sound.patch (503 bytes, patch)
2005-09-21 22:50 UTC, Mark Hobden
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hobden 2005-09-21 22:50:03 UTC
The recent big changes for mail/thunderbird altered the sed syntax for changing the libesd.so version number, this appears to
stop sed being able to find a match.

There appears to also be a similar line in the www/fieforx port.

Fix: Apply the patch to use the syntax from port version 1.0.6.
How-To-Repeat: Build thunderbird then in the options menu select a .wav file to be played when new messages arrive. No wav file gets played.
Comment 1 Jeremy Messenger freebsd_committer freebsd_triage 2005-09-22 18:19:48 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

freebsd-gnome@ maintains this port.
Comment 2 Jeremy Messenger 2005-09-22 23:28:10 UTC
Thanks for report and patch! I have a request, can you try to change it to  
like this.

=======================================
-	@${REINPLACE_CMD} -e 's|libesd\.so\.\d+|${ESD_LIB}|g' \
+	@${REINPLACE_CMD} -E -e 's|libesd\.so\.[0-9]+|libesd.so|g' \
=======================================

I would like to know if change it to libesd.so without have the major  
version in there will working. I can't test it, because I am deaf. I will  
asking my team if one of them can test it for me too.

Cheers,
Mezz


-- 
mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org
Comment 3 Jeremy Messenger 2005-09-23 18:37:21 UTC
On Thu, 22 Sep 2005 18:53:35 -0500, Mark Hobden <markhobden@gmail.com>  
wrote:

> On 9/22/05, Jeremy Messenger <mezz7@cox.net> wrote:
>> Thanks for report and patch! I have a request, can you try to change it  
>> to
>> like this.
>>
>> =======================================
>> -       @${REINPLACE_CMD} -e 's|libesd\.so\.\d+|${ESD_LIB}|g' \
>> +       @${REINPLACE_CMD} -E -e 's|libesd\.so\.[0-9]+|libesd.so|g' \
>> =======================================
>>
>> I would like to know if change it to libesd.so without have the major
>> version in there will working. I can't test it, because I am deaf. I  
>> will
>> asking my team if one of them can test it for me too.
>
> Hi Mezz,
>
> After recompiling the sound works with the new line in the Makefile :-)

Thanks for test it, I will commit those in the evening.

Cheers,
Mezz

> Thank-you,
>
> Mark


-- 
mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org
Comment 4 Jeremy Messenger freebsd_committer freebsd_triage 2005-09-23 21:43:45 UTC
State Changed
From-To: open->closed

Committed, thanks! That included firefox and mozilla(-devel) too.