Bug 86778 - [PATCH] audio/amarok: Fix OPTIONS handling
Summary: [PATCH] audio/amarok: Fix OPTIONS handling
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Landin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-01 09:20 UTC by Ulrich Spoerlein
Modified: 2005-10-10 17:02 UTC (History)
1 user (show)

See Also:

Attachments
amarok-1.3.2.patch (1.90 KB, patch)
2005-10-01 09:20 UTC, Ulrich Spoerlein 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Spoerlein 2005-10-01 09:20:20 UTC 
OPTIONS handling within audio/amarok are flawed. OPTIONS set *ALL* the
options that are defined as defaults. Now, if you want to check for an
override you have to check "the other" variable.

For example, XMMS is default-off, which means OPTIONS will set WITHOUT_XMMS.
Right now, the port will completely ignore a -DWITH_XMMS because it is for
WITHOUT_XMMS which is always set.

Fix below. NB: I did not test *all* the options, I only know it does the right
thing for XMMS, XINE and LIBVISUAL. Please review all the changes before
committing. Thanks!

I also only negated the if defined() stuff, this could be made better, if the
if-then-else sections were reversed. But I wanted to keep the diff minimal.

Port maintainer (mich@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.63
Comment 1 Markus Brueffer freebsd_committer freebsd_triage 2005-10-01 09:29:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mich

Over to maintainer
Comment 2 Michael Landin freebsd_committer freebsd_triage 2005-10-10 17:02:38 UTC 
State Changed
From-To: open->closed

Committed, thanks !