Bug 89740 - [MAINTAINER] editors/rospell: fix build on 4.x
Summary: [MAINTAINER] editors/rospell: fix build on 4.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Edwin Groothuis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-30 00:00 UTC by Ion-Mihai " IOnut " Tetcu
Modified: 2005-11-30 00:53 UTC (History)
0 users

See Also:


Attachments
Makefile.diff (857 bytes, patch)
2005-11-30 00:00 UTC, Ion-Mihai " IOnut " Tetcu
no flags Details | Diff
Makefile.diff (856 bytes, patch)
2005-11-30 00:42 UTC, Ion-Mihai " IOnut " Tetcu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ion-Mihai " IOnut " Tetcu 2005-11-30 00:00:22 UTC

4.x make doesn't know what BSDmakefile is so tekk it what to use.

Remove HAS_CONFIGURE= yes because we don't use distributed ./configure
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-30 00:13:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->edwin

Abort current build and retry with patch supplied.
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-30 00:16:27 UTC
State Changed
From-To: open->feedback

===>  Building for rospell-2005.03.b1 
---> Compiling ...  
In file included from src/rospell/spell.h:21, 
from src/rospell/main.cpp:29: 
src/rospell/utf8.h:72: syntax error before `!' 
src/rospell/utf8.h:82: extraneous `char' ignored 
src/rospell/utf8.h: In function `class UTF8 * strtoascii(char *)': 
src/rospell/utf8.h:88: no method `UTF8::chartoascii' 
src/rospell/utf8.h:93: return to `UTF8 *' from `char *' 

<jilles> Mavvie, hmm, a <ctype.h> macro collision :) 
<jilles> try #define _DONT_USE_CTYPE_INLINE_ before all #includes 

Tried his solution in main.cpp, but it didn't work.
Comment 3 Ion-Mihai " IOnut " Tetcu 2005-11-30 00:42:12 UTC
On Wed, 30 Nov 2005 00:25:11 GMT
Edwin Groothuis <edwin@FreeBSD.org> wrote:

> Synopsis: [MAINTAINER] editors/rospell: fix build on 4.x
> 
> State-Changed-From-To: open->feedback
> State-Changed-By: edwin
> State-Changed-When: Wed Nov 30 00:16:27 GMT 2005
> State-Changed-Why: 
> ===>  Building for rospell-2005.03.b1
> ---> Compiling ... 
> In file included from src/rospell/spell.h:21,
>                  from src/rospell/main.cpp:29:
> src/rospell/utf8.h:72: syntax error before `!'
> src/rospell/utf8.h:82: extraneous `char' ignored
> src/rospell/utf8.h: In function `class UTF8 * strtoascii(char *)':
> src/rospell/utf8.h:88: no method `UTF8::chartoascii'
> src/rospell/utf8.h:93: return to `UTF8 *' from `char *'
> 
> <jilles> Mavvie, hmm, a <ctype.h> macro collision :)
> <jilles> try #define _DONT_USE_CTYPE_INLINE_ before all #includes
> 
> Tried his solution in main.cpp, but it didn't work.

Grrr I'm tired of this, I've already ping-pong'ed with the author a few
times for his UTF* ... thought I got it all OK now :(

Suspend/close the PR (let it broken on 4.x); if you want put in the
modifications from the PR, except the BROKEN part (let's do "configure"
in do-configure:).

Eventually I'll try to work on it _if_ I have time (which I
doubt); 4.x isn't recommended anyway for desktops.



-- 
IOnut - Unregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"

BOFH excuse #214:
Fluorescent lights are generating negative ions. If turning them off
doesn't work, take them out and put tin foil on the ends.

Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-30 00:53:33 UTC
State Changed
From-To: feedback->closed

Committed, thanks!