Bug 90119 - update ports/www/typo
Summary: update ports/www/typo
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sam Lawrance
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-08 21:20 UTC by Vick Khera
Modified: 2005-12-16 10:40 UTC (History)
0 users

See Also:


Attachments
file.diff (933 bytes, patch)
2005-12-08 21:20 UTC, Vick Khera
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vick Khera 2005-12-08 21:20:05 UTC
	

update ports/www/typo to latest stable release; tighten up file permissions

Fix: according to docs, only the log and public dirs need to be writable by the
web server, not everything.  this patch addresses this issue by only making
those directories owned by the web user/group.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2005-12-08 21:24:37 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Jonathan Weiss 2005-12-10 11:53:33 UTC
> Maintainer of www/typo,
> 
> Please note that PR ports/90119 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/90119

The file permission part of the patch is ok with me, the update to 2.6.0 is
not. Typo 2.6.0 has some issues with the 0.13.1 version of Ruby on Rails
that is currently in the ports tree.

Rails 1.0 will be released next week and I'm planning on updating Typo to
2.6.0 after my update of the Rails port.

So this part of the patch can be commited:
-------------------------------------------------------
--- Makefile.orig    Thu Dec  8 15:34:46 2005
+++ Makefile    Thu Dec  8 16:07:50 2005
@@ -23,7 +23,8 @@
 
 do-install:
     ${CP} -R ${WRKSRC} ${PREFIX}/${TYPODIR}
-    ${CHOWN} -R ${WWWOWN}:${WWWGRP} ${PREFIX}/${TYPODIR}
+    ${CHOWN} -R ${WWWOWN}:${WWWGRP} ${PREFIX}/${TYPODIR}/log
+    ${CHOWN} -R ${WWWOWN}:${WWWGRP} ${PREFIX}/${TYPODIR}/public
 
 post-install:
     @${FIND} ${PREFIX}/${TYPODIR} -not -type d \
-------------------------------------------------------


Regards,
Jonathan

--
Jonathan Weiss
http://blog.innerewut.de
Comment 3 Sam Lawrance freebsd_committer freebsd_triage 2005-12-16 00:13:16 UTC
State Changed
From-To: feedback->open

Maintainer approved, with changes.
Comment 4 Sam Lawrance freebsd_committer freebsd_triage 2005-12-16 06:24:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lawrance

Grab
Comment 5 Sam Lawrance freebsd_committer freebsd_triage 2005-12-16 10:40:13 UTC
State Changed
From-To: open->closed

Committed, thanks!