Bug 90416 - Update port: multimedia/lxdvdrip add dependency
Summary: Update port: multimedia/lxdvdrip add dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-15 04:40 UTC by Serge Gagnon
Modified: 2005-12-16 16:13 UTC (History)
0 users

See Also:


Attachments
patch-lxdvdrip (929 bytes, text/plain)
2005-12-15 04:40 UTC, Serge Gagnon
no flags Details
patch-lxdvdrip-urN.diff (2.77 KB, patch)
2005-12-16 15:02 UTC, Serge Gagnon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Serge Gagnon 2005-12-15 04:40:02 UTC
	- Add multimedia/dvdwizard as RUN_DEPENDENCY
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2005-12-15 04:42:24 UTC
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2005-12-15 04:42:33 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Serge Gagnon 2005-12-15 05:13:29 UTC
Le 14 Décembre 2005 23:42, Edwin Groothuis a écrit :
> Maintainer of multimedia/lxdvdrip,

...
Sorry, submitter is maintainer. Submitter was too busy to make this simple 
task correct.

Or, if you want, i approved my patch ;)

-- 
GAGNON serge <serge.gagnon@b2b2c.ca>
PGP KEY-ID: 0xBBC1478F
PGP Fingerprint: B48B 4633 28F5 28F6 7A62 5650 69C8 E293 BBC1 478F
PPG Key: http://quenix2.dyndns.org:7777 | telnet quenix2.dyndns.org 7777
Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2005-12-15 06:22:55 UTC
State Changed
From-To: feedback->open

Submitter is maintainer with a different email address
Comment 5 Emanuel Haupt freebsd_committer freebsd_triage 2005-12-15 13:15:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Take.
Comment 6 Emanuel Haupt freebsd_committer freebsd_triage 2005-12-15 13:22:34 UTC
Why do you want to pull in multimedia/dvdwizard?

Emanuel
-- 
GnuPG key id: 0x55E67774         Download: http://pgp.mit.edu:11371
Key fingerprint: 17B3 FD8F BA68 4AB4 10FD  A9D1 AD52 6588 55E6 7774
Comment 7 Emanuel Haupt freebsd_committer freebsd_triage 2005-12-15 13:25:08 UTC
State Changed
From-To: open->feedback

Ask for maintainer feedback.
Comment 8 Serge Gagnon 2005-12-15 17:31:07 UTC
>Why do you want to pull in multimedia/dvdwizard?


In partcopy, the menu is wiped. It seems that dvdwizard can help to build a 
new one.

From /usr/local/share/doc/lxdvdrip/README.en
...
- For DVDs with Menu the dvdwizard >= 0.4.2 is needed, too:
  http://www.wershofen.de/downloads/dvdwizard.tar.gz
  http://udrecsuite.sourceforge.net/doku_dvdwizard.html
...
DVD with Menu
=============

Through Integration of the dvdwizard the DVD gets a Menu.
The Backup gets a light Menu with Buttons to select and start the Title, the 
Audiotrack and a Chapteroverview.

For more Information take a look at "README.dvdwiard.en".
...


-- 
GAGNON serge <serge.gagnon@b2b2c.ca>
PGP KEY-ID: 0xBBC1478F
PGP Fingerprint: B48B 4633 28F5 28F6 7A62 5650 69C8 E293 BBC1 478F
PPG Key: http://quenix2.dyndns.org:7777 | telnet quenix2.dyndns.org 7777
Comment 9 Emanuel Haupt freebsd_committer freebsd_triage 2005-12-15 18:05:21 UTC
State Changed
From-To: feedback->open

Feedback received.
Comment 10 Emanuel Haupt freebsd_committer freebsd_triage 2005-12-16 08:51:17 UTC
> A bug was found by lioux@FreeBSD.org when using lxdvdrip in trans_par
> mode.
> 
> First, lxdvdrip need misc/buffer to run in this mode.
> Second, I had to change a value when lxdvdrip call misc/buffer to
> avoid a  malfunction. (perhaps a restriction in buffer anyway, it
> works well)
> 
> I have successfully tested lxdvdrip in this mode.

Can you please follow up (or send a new PR) with a unified, recursive
patch (-Nur) against the version in the ports?

Thanks,
Emanuel
-- 
GnuPG key id: 0x55E67774         Download: http://pgp.mit.edu:11371
Key fingerprint: 17B3 FD8F BA68 4AB4 10FD  A9D1 AD52 6588 55E6 7774
Comment 11 Emanuel Haupt freebsd_committer freebsd_triage 2005-12-16 08:53:54 UTC
State Changed
From-To: open->feedback

Ask for unified, recursive patch against ports version.
Comment 12 Serge Gagnon 2005-12-16 15:02:41 UTC
Of course :)

-- 
GAGNON serge <serge.gagnon@b2b2c.ca>
PGP KEY-ID: 0xBBC1478F
PGP Fingerprint: B48B 4633 28F5 28F6 7A62 5650 69C8 E293 BBC1 478F
PPG Key: http://quenix2.dyndns.org:7777 | telnet quenix2.dyndns.org 7777
Comment 13 Emanuel Haupt freebsd_committer freebsd_triage 2005-12-16 16:13:24 UTC
State Changed
From-To: feedback->closed

Committed, thanks!