These ports are using the variable name CONF_FILES : - mail/dsbl-testers (dean@odyssey.apana.org.au) - mail/elm+ME (ports@FreeBSD.org) - net/dcd (mraleks@bk.ru) - net/isc-dhcp3-server (Joerg.Pulz@frm2.tum.de) - security/amap (rabbi@abditum.com) - security/openscep (vsevolod@FreeBSD.org) - sysutils/epylog (alan@wave2.co.uk) - done ports/90436 has a new way to handle configuration files and the ports are likely to be broken once the patch hits the tree. Please rename this variable within an acceptable time frame (I'm fixing maintainer timeout to one month, or less it the bsd.port.mk patch is committed before). Fix: s/CONF_FILES/LOCAL_CONF_FILES/g or whatever the name.
Responsible Changed From-To: freebsd-ports-bugs->flz I'll take it.
Le Jeudi 15 décembre 2005 à 16:16 +0000, Florent Thoumie a écrit : > >Description: > > These ports are using the variable name CONF_FILES : > > - mail/dsbl-testers (dean@odyssey.apana.org.au) > - mail/elm+ME (ports@FreeBSD.org) > - net/dcd (mraleks@bk.ru) > - net/isc-dhcp3-server (Joerg.Pulz@frm2.tum.de) > - security/amap (rabbi@abditum.com) > - security/openscep (vsevolod@FreeBSD.org) > - sysutils/epylog (alan@wave2.co.uk) > > ports/90436 has a new way to handle configuration files and the ports are likely > to be broken once the patch hits the tree. > > Please rename this variable within an acceptable time frame (I'm fixing maintainer timeout to one month, or less it the bsd.port.mk patch is committed before). > > >How-To-Repeat: > > >Fix: > > s/CONF_FILES/LOCAL_CONF_FILES/g or whatever the name. Please have a look at this PR. -- Florent Thoumie flz@FreeBSD.org FreeBSD committer
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thu, 15 Dec 2005, Florent Thoumie wrote: > Le Jeudi 15 décembre 2005 à 16:16 +0000, Florent Thoumie a écrit : > >>> Description: >> >> These ports are using the variable name CONF_FILES : >> >> - mail/dsbl-testers (dean@odyssey.apana.org.au) >> - mail/elm+ME (ports@FreeBSD.org) >> - net/dcd (mraleks@bk.ru) >> - net/isc-dhcp3-server (Joerg.Pulz@frm2.tum.de) >> - security/amap (rabbi@abditum.com) >> - security/openscep (vsevolod@FreeBSD.org) >> - sysutils/epylog (alan@wave2.co.uk) >> >> ports/90436 has a new way to handle configuration files and the ports are likely >> to be broken once the patch hits the tree. >> >> Please rename this variable within an acceptable time frame (I'm fixing maintainer timeout to one month, or less it the bsd.port.mk patch is committed before). >> >>> How-To-Repeat: >> >>> Fix: >> >> s/CONF_FILES/LOCAL_CONF_FILES/g or whatever the name. > > Please have a look at this PR. Hi Florent, attached you will find the patch for net/isc-dhcp3-server. Actually, i've one question: isn't the line ${INSTALL_DATA} ${PREFIX}/${conf}${CONF_SUFX} ${PREFIX}/${conf} in your patch overwriting already existing ${conf} files with the sample version? I'm not sure, but a short test with a very simple self written Makefile has overwritten ${PREFIX}/${conf} with ${PREFIX}/${conf}${CONF_SUFX}, regardless of any changes made to ${PREFIX}/${conf} before. If you can confirm this, you should probably insert a small test(1) line before to prevent from overwriting already existing and working configuration files during a simple upgrade. Please correct me if i'm wrong Joerg - -- The beginning is the most important part of the work. -Plato -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDoaoZSPOsGF+KA+MRAnT2AJ9Svqkmzrv9aZfSk4YpRlJLfjAT1wCfcV41 Dt+vNRPsZNkIIM7IVF07mRw= =Ucnq -----END PGP SIGNATURE-----
Le Jeudi 15 décembre 2005 à 18:38 +0100, Joerg Pulz a écrit : > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > On Thu, 15 Dec 2005, Florent Thoumie wrote: > > > Le Jeudi 15 décembre 2005 à 16:16 +0000, Florent Thoumie a écrit : > > > >>> Description: > >> > >> These ports are using the variable name CONF_FILES : > >> > >> - mail/dsbl-testers (dean@odyssey.apana.org.au) > >> - mail/elm+ME (ports@FreeBSD.org) > >> - net/dcd (mraleks@bk.ru) > >> - net/isc-dhcp3-server (Joerg.Pulz@frm2.tum.de) > >> - security/amap (rabbi@abditum.com) > >> - security/openscep (vsevolod@FreeBSD.org) > >> - sysutils/epylog (alan@wave2.co.uk) > >> > >> ports/90436 has a new way to handle configuration files and the ports are likely > >> to be broken once the patch hits the tree. > >> > >> Please rename this variable within an acceptable time frame (I'm fixing maintainer timeout to one month, or less it the bsd.port.mk patch is committed before). > >> > >>> How-To-Repeat: > >> > >>> Fix: > >> > >> s/CONF_FILES/LOCAL_CONF_FILES/g or whatever the name. > > > > Please have a look at this PR. > > Hi Florent, > > attached you will find the patch for net/isc-dhcp3-server. > > Actually, i've one question: isn't the line > ${INSTALL_DATA} ${PREFIX}/${conf}${CONF_SUFX} ${PREFIX}/${conf} > in your patch overwriting already existing ${conf} files with the sample > version? I'm not sure, but a short test with a very simple self written > Makefile has overwritten ${PREFIX}/${conf} with > ${PREFIX}/${conf}${CONF_SUFX}, regardless of any changes made to > ${PREFIX}/${conf} before. > If you can confirm this, you should probably insert a small test(1) line > before to prevent from overwriting already existing and working > configuration files during a simple upgrade. > > Please correct me if i'm wrong > Joerg True, I've removed too much of the initial patch. Thanks ! -- Florent Thoumie flz@FreeBSD.org FreeBSD committer
State Changed From-To: open->closed Committed. Thanks!