Bug 91151 - [PATCH] misc/tinderbox: correct PHP depends.
Summary: [PATCH] misc/tinderbox: correct PHP depends.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Edwin Groothuis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-31 23:10 UTC by Andrey Slusar
Modified: 2006-01-03 00:01 UTC (History)
1 user (show)

See Also:

Attachments
tinderbox.diff (940 bytes, patch)
2005-12-31 23:10 UTC, Andrey Slusar 		no flags Details | Diff
tinderbox.diff (827 bytes, patch)
2006-01-02 23:48 UTC, Andrey Slusar 		no flags Details | Diff
file.dat (21 bytes, text/plain; charset=iso-8859-1)
2006-01-02 23:48 UTC, Andrey Slusar 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Slusar freebsd_committer freebsd_triage 2005-12-31 23:10:03 UTC 
	* Correct PHP depends.
	* Change not needed includes bsd.port.pre.mk and bsd.port.post.mk to
	  bsd.port.mk(now OPTIONS work in bsd.port.mk).
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2005-12-31 23:33:01 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->edwin

Over to maintainer
Comment 2 Andrey Slusar freebsd_committer freebsd_triage 2005-12-31 23:35:46 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Andrey Slusar freebsd_committer freebsd_triage 2005-12-31 23:58:57 UTC 
State Changed
From-To: feedback->open

It's edwin terrytory. Please, change MANTAINER to @FreeBSD.org
Comment 4 edwin 2006-01-02 04:03:04 UTC 
On Sun, Jan 01, 2006 at 01:07:07AM +0200, Andrey Slusar wrote:
> 	* Change not needed includes bsd.port.pre.mk and bsd.port.post.mk to
> 	  bsd.port.mk(now OPTIONS work in bsd.port.mk).

Can you give me an example on this? My depends-list doesn't include
any postgresql or mysql dependencies when I don't use bsd.port.pre.mk:

before:
    [~/cvs/ports/misc/tinderbox] edwin@k7>make all-depends-list | grep datab
    /usr/ports/databases/mysql41-client
    /usr/ports/databases/p5-DBD-mysql
    /usr/ports/databases/p5-DBI
    /usr/ports/databases/pear-DB
    /usr/ports/databases/php4-mysql
    /usr/ports/databases/php4-pgsql
    /usr/ports/databases/postgresql81-client

after:
    [~/cvs/ports/misc/tinderbox] edwin@k7>make all-depends-list | grep database
    /usr/ports/databases/pear-DB

Edwin
-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/
Comment 5 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-02 11:10:58 UTC 
State Changed
From-To: open->feedback

Awaiting submitter feedback
Comment 6 Andrey Slusar freebsd_committer freebsd_triage 2006-01-02 23:48:29 UTC 
It's my mistake - depends is broke.

See fixed patch for (1).
Comment 7 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-03 00:00:55 UTC 
State Changed
From-To: feedback->closed

Commited