When www/apache22 and www/mod_perl2 are installed www/p5-Apache-DBI will not install. This is because it explicitly looks for PREFIX/libexec/apache2/mod_perl.so when WITH_MODPERL2 is defined. With www/apache22 the path is PREFIX/libexec/apache22/mod_perl.so My submitted patch dynamically looks up the libexec path for apache modules with a call to apxs, it falls back to the hardcoded path. This approach is used successfully by other modules (see www/mod_auth_kerb or www/p5-CGI-SpeedyCGI for example). Port maintainer (pgollucci@p6m7g8.com) is cc'd. Generated with FreeBSD Port Tools 0.63
State Changed From-To: open->feedback Awaiting maintainers feedback
Edwin Groothuis wrote: > Maintainer of www/p5-Apache-DBI, > > Please note that PR ports/91526 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/91526 > Approved -- I agree with the concept, but am unable to view the patch ???? Also, Now that CPAN has fixed it's indexing for this module, we can switch back to it :) MASTER_SITES= ${MASTER_SITE_PERL_CPAN} MASTER_SITE_SUBDIR= Apache instead of pulling it from Apache. HTH -- ------------------------------------------------------------------------ "Love is not the one you can picture yourself marrying, but the one you can't picture the rest of your life without." "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..." "I wanna hold ya till I die ... I wanna hold ya till the fear in me subsides." Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
State Changed From-To: feedback->open Maintainer approves
State Changed From-To: open->feedback Paul, The patch is missing, can you resupply it? Edwin
Sorry about that, not sure how I left that off. The diff is attached. It includes the modification of the MASTER_SITES as well as an upgrade to 0.9901 (0.98 is not available on CPAN so the upgrade was necessary to modify MASTER_SITES as well as to provide the new, improved version).
State Changed From-To: feedback->open Patch recieived
I'm not sure why the last few email's I sent failed to update the case but here it goes again. The maintainer has approved this patch (as per the email below), please commit. Thanks, Paul > From: pgollucci@p6m7g8.com > Subject: Re: ports/91526: [PATCH] Fix www/p5-Apache-DBI so that it > works with www/apache22 > Date: January 12, 2006 9:29:02 PM EST > To: paul@aps.org > > Paul Dlug wrote: > >> I was just wondering if you had a chance to review this patch, it >> would be helpful to get it committed. >> > I thought I already had ? > > Committ away... FYI, I'm going to roll Apache-DBI 1.0 towars the > start of February on CPAN.. >
files/patch-mp2-api is no longer needed. Also, this PR will fix PR 89387 so please close that one and commit this one.
Class Changed From-To: update->maintainer-update Fix class.
Responsible Changed From-To: freebsd-ports-bugs->vd Take
State Changed From-To: open->closed Committed, thanks!