Bug 92072 - databases/rubygem-activerecord: MySQL options & portlint(1) cleanup
Summary: databases/rubygem-activerecord: MySQL options & portlint(1) cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Vasil Dimov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-20 19:20 UTC by Roderick van Domburg
Modified: 2006-01-23 16:48 UTC (History)
0 users

See Also:

Attachments
patch-rubygem-activerecord-mysql (1.06 KB, text/plain)
2006-01-20 19:20 UTC, Roderick van Domburg 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roderick van Domburg 2006-01-20 19:20:03 UTC 
This patch adds a nifty options screen so that users can pull in the native
MySQL bindings. These bindings increase Rails' database performance by a
said 10-15%.

I turned the option off by default, to prevent annoyances for non-MySQL
users. While I was here, I fixed several portlint(1) warnings as well.
Comment 1 Roderick van Domburg 2006-01-20 19:29:19 UTC 
Reply-To should be r.s.a.vandomburg@student.utwente.nl.
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-20 21:31:31 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Jonathan Weiss 2006-01-22 13:07:37 UTC 
Cheers,


The patch looks ok, I've updated it to include support for PostgreSQL 
and SQLite3 bindings:


-------------------------------------
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/rubygem-activerecord/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	21 Jan 2006 20:25:05 -0000	1.5
+++ Makefile	22 Jan 2006 11:20:03 -0000
@@ -6,17 +6,37 @@

  PORTNAME=	activerecord
  PORTVERSION=	1.13.2
-PORTREVISION=	1
+PORTREVISION=	2
  CATEGORIES=	databases rubygems
+MASTER_SITES=	http://rubyforge.org/frs/download.php/7641/

  MAINTAINER=	jw@innerewut.de
  COMMENT=	Object-relational mapping layer for Rails MVC Framework

-MASTER_SITES=	http://rubyforge.org/frs/download.php/7641/
-
  BUILD_DEPENDS= 
${LOCALBASE}/${SPEC_DIR}/activesupport-1.2.5.gemspec:${PORTSDIR}/devel/rubygem-activesupport
  RUN_DEPENDS=	${BUILD_DEPENDS}

+OPTIONS=	NATIVE_MYSQL "Use native MySQL bindings" Off\
+		NATIVE_POSTGRESQL "Use native PostgreSQL bindings" Off\
+		NATIVE_SQLITE3 "Use native SQLite3 bindings" Off
+OPTIONSFILE=	${PORT_DBDIR}/rubygem-${PORTNAME}/options
+
+# to get RUBY_SITEARCHLIBDIR
+USE_RUBY=	yes
+
  .include <bsd.port.pre.mk>
+
+.if defined(WITH_NATIVE_MYSQL)
+RUN_DEPENDS+= 
${RUBY_SITEARCHLIBDIR}/mysql.so:${PORTSDIR}/databases/ruby-mysql
+.endif
+
+.if defined(WITH_NATIVE_POSTGRESQL)
+RUN_DEPENDS+= 
${RUBY_SITEARCHLIBDIR}/postgres.so:${PORTSDIR}/databases/ruby-postgres
+.endif
+
+.if defined(WITH_NATIVE_SQLITE3)
+RUN_DEPENDS+= 
${RUBY_SITEARCHLIBDIR}/sqlite3_api.so:${PORTSDIR}/databases/ruby-sqlite3
+.endif
+
  .include "${PORTSDIR}/devel/ruby-gems/Makefile.common"
  .include <bsd.port.post.mk>
-------------------------------------


Regards,
Jonathan
-- 
Jonathan Weiss
http://blog.innerewut.de
Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-22 20:37:58 UTC 
State Changed
From-To: feedback->open

maintainer approved with additional patch.
Comment 5 Vasil Dimov freebsd_committer freebsd_triage 2006-01-23 14:54:50 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->vd

Take
Comment 6 Vasil Dimov freebsd_committer freebsd_triage 2006-01-23 16:42:04 UTC 
State Changed
From-To: open->closed

Committed, thanks!