Bug 92374 - [PATCH] IIIMF-related ports (textporc/iiimf-* etc): fix dependency and pacify portlint
Summary: [PATCH] IIIMF-related ports (textporc/iiimf-* etc): fix dependency and pacify...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Simon Barner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-26 15:30 UTC by Masanori OZAWA
Modified: 2006-02-06 12:06 UTC (History)
0 users

See Also:


Attachments
file.diff (13.99 KB, patch)
2006-01-26 15:30 UTC, Masanori OZAWA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Masanori OZAWA 2006-01-26 15:30:08 UTC
textproc/iiimf-csconv:
- fix dependency (add USE_GETTEXT)

other (textproc/iiimf-*, chinese/iiimf-newpy, chinese/iiimf-ude,
japanese/iiimf-le-canna, japanese/iiimf-le-freewnn, korean/iiimf-le-hangul):
- pacify portlint
Comment 1 Simon Barner freebsd_committer freebsd_triage 2006-02-06 11:28:46 UTC
Responsible Changed
From-To: freebsd-ports-bugs->barner

I'll take it.
Comment 2 Simon Barner freebsd_committer freebsd_triage 2006-02-06 11:56:54 UTC
State Changed
From-To: open->closed

Hi, 

I just committed your update. Some notes: 

- PORTREVISION bumps are not necessary if the behaviour of the _installed 
package_ remains the same. In this case, I only kept the bump for 
textproc/iiimf-csconv (because of the addition of the gettext 
dependency). 

- I changed the IGNORE lines, so a correct phrase is printed. Hint: 
You can test them in the following way: 

make OSVERSION=500000 

This will fake your OS version and thus print the message. 

- According to portlint, some ports install .la files. You might want to 
consider using libtool for these ports. 

- textproc/iiimf-gnome-im-switcher handles the installation of OMF files 
on its own. Please see the corresponding portlint output how to do it 
more correctly. 

Otherwise, your ports look good (thanks a lot for maintaining them btw.!). 

Cheers, 
Simon