This is an update of www/resin3 to 3.0.18. The attached patch also unbreaks the port, see PR 93289
Responsible Changed From-To: freebsd-ports-bugs->vd Take
Hello! Is there a chance it will be committed? With respect, Boris
On Thu, Mar 30, 2006 at 03:10:22AM +0000, Boris Kovalenko wrote: > > Is there a chance it will be committed? > I got an objection about the patch from portmgr, here is it: --- snip --- On Thu, Mar 09, 2006 at 08:33:59AM +0200, Vasil Dimov wrote: > On Thu, Mar 09, 2006 at 01:24:34AM -0500, Kris Kennaway wrote: > > On Thu, Mar 09, 2006 at 08:18:07AM +0200, Vasil Dimov wrote: > > > Update to 3.0.18 and unbreak by fixing the hardcoded -lc_r > > > > AFAICT the maintainer didn't respond to my concerns about this patch. > > Please wait until he does so. > > > > What are your concerns about the patch? There is nothing followedup to > the PR (94131). Did you send him a private letter, maybe he did not > receive it? I replied on a mailing list when he posted the patch. Basically he's linking everything in sight to ${PTHREAD_LIB} (since it's added globally to CFLAGS instead of just fixing the linker lines), which may include binaries or libraries that are not threaded. That needs to be clarified. --- snip --- Can you inspect this? It should be easy to deal with. % find /usr/ports -mindepth 3 -maxdepth 3 -name Makefile |xargs grep REINPLACE |grep PTHREAD |grep c_r may be useful Sorry for the delay, I should have contacted you right after I got Kris' objection. -- Vasil Dimov gro.DSBeerF@dv Testing can show the presence of bugs, but not their absence. -- Edsger W. Dijkstra
State Changed From-To: open->closed I committed the patch sent to me today by the maintainer