Bug 94188 - multimedia/libdv reorder_block() incorrect on non-x86
Summary: multimedia/libdv reorder_block() incorrect on non-x86
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mario Sergio Fujikawa Ferreira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-07 21:00 UTC by Brent Casavant
Modified: 2006-12-15 01:40 UTC (History)
0 users

See Also:

Attachments
file.diff (692 bytes, patch)
2006-03-07 21:00 UTC, Brent Casavant 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Casavant 2006-03-07 21:00:15 UTC 
In libdv 0.104, the reorder_block() zigzag behaves incorrectly in the !ARCH_X86 && !ARCH_X86_64 case.  The current code fails to take into account the effects of _dv_prepare_reorder_tables(), which changes the indexes contained in the reorder_88[] and reorder_248[] arrays.

Fix: This is the patch I submitted to libdv-dev@lists.sourceforge.net:
How-To-Repeat: Encode a DV stream on a non-x86 build of libdv.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2006-03-07 21:14:03 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->lioux

Over to maintainer.
Comment 2 Brent Casavant 2006-03-07 23:57:57 UTC 
I should note that the PR submission form slightly mangled the patch.

The "-" lines should all be contiguous, with the line beginning
"reorder[i])" part of the previous lines.

Brent

-- 
Brent Casavant                          All music is folk music.  I ain't
bcasavan@sgi.com                        never heard a horse sing a song.
Silicon Graphics, Inc.                    -- Louis Armstrong
Comment 3 Mario Sergio Fujikawa Ferreira freebsd_committer freebsd_triage 2006-12-15 01:28:57 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-12-15 01:39:14 UTC 
lioux       2006-12-15 01:28:36 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/libdv     Makefile 
  Added files:
    multimedia/libdv/files patch-libdv__encode.c 
  Log:
  o Fix: the reorder_block() zigzag behaves incorrectly in the
  
  (!ARCH_X86 && !ARCH_X86_64)
  
  case. The current code fails to take into account the effects of
  _dv_prepare_reorder_tables(), which changes the indexes contained
  in the reorder_88[] and reorder_248[] arrays.
  
  o Bump PORTREVISION
  
  PR:             94188
  Submitted by:   Brent Casavant <bcasavan@sgi.com>
  
  Revision  Changes    Path
  1.35      +1 -1      ports/multimedia/libdv/Makefile
  1.1       +12 -0     ports/multimedia/libdv/files/patch-libdv__encode.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"