Bug 94461 - [patch] to build print/ghostscript-afpl with GCC41
Summary: [patch] to build print/ghostscript-afpl with GCC41
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Vasil Dimov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-15 05:20 UTC by Ron MacNeil
Modified: 2006-06-14 10:55 UTC (History)
0 users

See Also:


Attachments
file.diff (7.97 KB, patch)
2006-03-15 05:20 UTC, Ron MacNeil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ron MacNeil 2006-03-15 05:20:16 UTC
print/ghostscript-afpl is not currently buildable with GCC 4.1

Fix: Add the following as a new patch file in print/ghostscript-afpl/files:
Comment 1 Vasil Dimov freebsd_committer freebsd_triage 2006-05-09 15:05:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vd

Take
Comment 2 Vasil Dimov freebsd_committer freebsd_triage 2006-05-09 16:12:43 UTC
State Changed
From-To: open->closed

Committed, thanks! 
Note that the patch against gdevlips-2.4.0/gdevl4v.c was not necessary
Comment 3 Ron MacNeil 2006-06-11 11:44:44 UTC
Cheers, vd.

Actualy, that gdevl4v.c patch was necessary, as it adds a missing "private 
int" to a declaration that gcc41 (and possibly gcc40) can't live without.

I've since noticed that there's an existing patch file 
"files/patch-lips:gdevl4v.c" so below is a patch against that file which 
adds the missing declaration (and adjusts the rest of the patch file 
accordingly) in case you think that's a better way to go.

Best,
Ron
Comment 4 Ron MacNeil 2006-06-11 11:49:04 UTC
Cheers, vd.

Actualy, that gdevl4v.c patch was necessary, as it adds a missing "private 
int" to a declaration that gcc41 (and possibly gcc40) can't live without.

I've since noticed that there's an existing patch file 
"files/patch-lips:gdevl4v.c" so below is a patch against that patch which 
adds the missing declaration (and adjusts the rest of the patch file 
accordingly) in case you think that's a better way to go.

Best,
Ron



--- orig-patch-lips:gdevl4v.c	Sun Jun 11 20:00:34 2006
+++ patch-lips:gdevl4v.c	Sun Jun 11 20:03:36 2006
@@ -1,6 +1,6 @@
--- lips/gdevl4v.c.orig	Thu Nov  2 12:09:18 2000
+++ lips/gdevl4v.c	Tue Jan 13 01:30:38 2004
-@@ -230,41 +230,66 @@
+@@ -230,41 +230,67 @@
  };

  /* Vector device implementation */
@@ -40,6 +40,7 @@
+lips4v_curveto(gx_device_vector * vdev, floatp x0, floatp y0, floatp x1,
+		floatp y1, floatp x2, floatp y2, floatp x3, floatp y3,
+		gx_path_type_t type);
++private int
+lips4v_closepath(gx_device_vector * vdev, floatp x, floatp y, floatp 
x_start,
+		  floatp y_start, gx_path_type_t type);

@@ -92,7 +93,7 @@
  private int lips4v_setlinewidth(gx_device_vector * vdev, floatp width);
  private int lips4v_setlinecap(gx_device_vector * vdev, gs_line_cap cap);
  private int lips4v_setlinejoin(gx_device_vector * vdev, gs_line_join 
join);
-@@ -758,10 +783,26 @@
+@@ -758,10 +784,26 @@
      /* Íѻ極¥¤¥º */
      if (pdev->prev_paper_size != paper_size) {
  	if (paper_size == USER_SIZE) {
@@ -121,7 +122,7 @@
  	    lputs(s, paper);
  	} else {
  	    sprintf(paper, "%c%dp", LIPS_CSI, paper_size);
-@@ -770,12 +811,28 @@
+@@ -770,12 +812,28 @@
      } else if (paper_size == USER_SIZE) {
  	if (pdev->prev_paper_width != width ||
  	    pdev->prev_paper_height != height)
@@ -152,7 +153,7 @@
  	lputs(s, paper);
      }
      pdev->prev_paper_size = paper_size;
-@@ -1881,7 +1938,7 @@
+@@ -1881,7 +1939,7 @@
  	}
  	color_set_pure(&color, one);
  	code = gdev_vector_update_fill_color((gx_device_vector *) pdev,
Comment 5 Vasil Dimov freebsd_committer freebsd_triage 2006-06-11 13:29:38 UTC
State Changed
From-To: closed->analyzed

I am looking into the issue with the "private int" declaration.
Comment 6 Vasil Dimov freebsd_committer freebsd_triage 2006-06-14 10:46:15 UTC
State Changed
From-To: analyzed->closed

I committed the `private int' fix, thanks!