Bug 94914 - [maintainer] update net/gatekeeper to v2.2.3-2
Summary: [maintainer] update net/gatekeeper to v2.2.3-2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-24 22:00 UTC by Joerg Pulz
Modified: 2006-03-28 12:30 UTC (History)
1 user (show)

See Also:


Attachments
gatekeeper.diff (12.01 KB, patch)
2006-03-24 22:00 UTC, Joerg Pulz
no flags Details | Diff
gatekeeper.diff (1.13 KB, patch)
2006-03-28 09:23 UTC, Joerg Pulz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joerg Pulz 2006-03-24 22:00:33 UTC
	Update net/gatekeeper to the latest version v2.2.3-2
	Makefile:
	  - chase new version
	  - make use of DISTVERSION to handle the version number
	  - convert to use the new versions of devel/pwlib and net/openh323
	  - convert to the new USE_RC_SUBR style
	  - remove NOCLEANDEPENDS, its only of use for the old pwlib/openh323
	  - remove other useless stuff (pre-install, USE_BISON, ...)
	  - make use of DOCSDIR and EXAMPLESDIR like in net/openam
	  - add WITH_RADIUS knob instead of enabling it by default
	  - enable the MySQL and PostGreSQL backends
	  - add pre-everything to give users a hint about the available knobs
	  - adjust directories in do-install, add DOCS installation
	  - remove useless line from post-install
	distinfo:
	  - regen for the new distfile
	pkg-plist:
	  - let USE_RC_SUBR handle the rcNG script removal when deinstalling
	  - add documentation files
	  - make use of EXAMPLESDIR and DOCSDIR
	pkg-install:
	  - adjust the path for examples
	  - add documentation part
	files/gnugk.sh.sample
	  - removed
	files/gnugk.sh.in
	  - is a copy of gnugk.sh.sample to get it handled by USE_RC_SUBR
	files/patch-Makefile.in
	  - removed, no longer needed

Fix: Apply the patch, add new files and delete emty files.
Comment 1 Sergey Matveychuk freebsd_committer freebsd_triage 2006-03-26 18:39:06 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 2 Joerg Pulz 2006-03-28 09:23:46 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Sun, 26 Mar 2006, Sergey Matveychuk wrote:

> It does not build on 4.11, but I'll commit it with BROKEN tag.
>
> In file included from radproto.cxx:145:
> radproto.h:586: anonymous class type not used to declare any objects
> radproto.h:588: anonymous class type not used to declare any objects
> radproto.h: In method `RadiusAttr::RadiusAttr(const RadiusAttr &)':
> radproto.h:232: `class RadiusAttr' has no member named `m_length'
> radproto.h: In method `unsigned char RadiusAttr::GetType() const':
> radproto.h:336: `m_type' undeclared (first use this function)
> radproto.h:336: (Each undeclared identifier is reported only once
> radproto.h:336: for each function it appears in.)
> radproto.h: In method `unsigned char RadiusAttr::GetVsaType() const':
> radproto.h:344: `m_length' undeclared (first use this function)
> radproto.h:344: `m_vendorType' undeclared (first use this function)

Hi Sergey,

did you try to compile it on 4.11 with WITH_RADIUS=1 ?
Thanks for fixing this.

Attached is another short patch which fixes a spelling bug in pkg-install 
and adds a line to pkg-plist to forcestop gnugk on systems where the rcNG 
script is installed without the .sh filename extension.

I found the rcNG problem yesterday when i was working on an update to 
sysutils/nut*.
The rcNG script itself is correctly added to TMPPLIST but there is no way 
to get the filename (gnugk or gnugk.sh) from bsd.port.mk without doubling 
the effort and to do the same check, as in bsd.port.mk, in the ports 
Makefile again.
I think this needs some twaeking to provide an easy way for porters to 
run an rcNG script forcestop when the port gets deinstalled.

regards
Joerg

- -- 
The beginning is the most important part of the work.
 				-Plato
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (FreeBSD)

iD8DBQFEKPKUSPOsGF+KA+MRAtdeAJ9yRd2zZuZkEh0jC9Gt404r4eloowCgp6f6
JHzla3ZiiY38XJ3V7Dn18t0=
=IGVp
-----END PGP SIGNATURE-----
Comment 3 Sergey Matveychuk freebsd_committer freebsd_triage 2006-03-28 12:25:06 UTC
Joerg Pulz wrote:
> did you try to compile it on 4.11 with WITH_RADIUS=1 ?

This code prevent it:
.if ${OSVERSION} >= 500000
. if defined(WITH_RADIUS)
CONFIGURE_ARGS+=        --enable-radius
. else
CONFIGURE_ARGS+=        --disable-radius
. endif
.endif

But I'll try to disable it and recheck.

> I found the rcNG problem yesterday when i was working on an update to
> sysutils/nut*.
> The rcNG script itself is correctly added to TMPPLIST but there is no
> way to get the filename (gnugk or gnugk.sh) from bsd.port.mk without
> doubling the effort and to do the same check, as in bsd.port.mk, in the
> ports Makefile again.
> I think this needs some twaeking to provide an easy way for porters to
> run an rcNG script forcestop when the port gets deinstalled.

I've proposed a solution: ports/93373. Let's wait for a portmgr's decision.

-- 
Sem.