Bug 96543 - [PATCH] emulators/vmware3: fix checking for linprocfs.ko
Summary: [PATCH] emulators/vmware3: fix checking for linprocfs.ko
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-30 12:30 UTC by never
Modified: 2006-07-09 21:13 UTC (History)
0 users

See Also:

Attachments
file.diff (676 bytes, patch)
2006-04-30 12:30 UTC, never 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description never 2006-04-30 12:30:11 UTC 
	In case of MODULES_WITH_WORLD=yes in /etc/make.conf, modules are being
	installed to /boot/modules/ and that's why existing check for linprocfs.ko
	in emulators/vmware3/Makefile says that user does not have linprocfs.ko,
	while it exists in /boot/modules/

Fix: Please apply patch attached.
How-To-Repeat: 	echo MODULES_WITH_WORLD=yes >> /etc/make.conf
	cd /usr/src
	make buildworld
	make buildkernel
	make installkernel
	make installworld
	cd /usr/ports/emulators/vmware3
	make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-04-30 12:32:09 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 orlando 2006-05-03 00:33:42 UTC 
This, along ports/96491 look fine, although I would finally drop
the dependency over /usr/src and replace what was really meant to
be /usr/src/sys.

Here's the diff after merging ports/96543 and ports/96491:

--- Makefile~	Tue May  2 23:02:08 2006
+++ Makefile	Tue May  2 23:02:47 2006
@@ -64,7 +64,7 @@
IGNORE=		linprocfs is required, please build the module and/or add it  
to your kernel
.endif
-.if !exists(${SRC_BASE}/Makefile)
+.if !exists(${SRC_BASE}/sys/Makefile)
IGNORE=		kernel source files required
.endif

Thanks
Orlando
Comment 3 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-07-09 21:13:29 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!