Class Changed From-To: maintainer-update->change-request Fix category (new ports should be change-requests)
I really think that www/xpi-cutemenus-crystalsvg will be a better location. Package name is one thing, we can alter it later. But ugly folder names in our ports collection is really not very desirable. Thanks for your interest in xpi thingie, Lapo :-) Thanks!
I agree, it seemed a bit ugly to me as well, but didn't really think about it. I will rename and test it again later, or possibly tomorrow.
On 5/4/06, Lapo Luchini <lapo@lapo.it> wrote: > I agree, it seemed a bit ugly to me as well, but didn't really think > about it. > I will rename and test it again later, or possibly tomorrow. I don't think there's need for additional testing unless a committer requests it. Most likely he'll handle dirname change all by himself. If you want to change portname, too, then, indeed, you should test you port again and submit a new shar.
Yes, I do prefer when port name and port directory match. So I changed it and made a patch (only the Makefile changed). It would be great to add directly to Makefile.xpi support for an optional "XPI_NAME" (or something like that) variable in order to avoid having to re-define MASTER_SITE_SUBDIR and DISTNAME in each Makefile =) Patch follows: mv /usr/ports/www/xpi-cutemenus_-_crystal_svg /usr/ports/www/xpi-cutemenus-crystalsvg --- MAkefile.orig Fri May 5 12:28:00 2006 +++ Makefile Fri May 5 12:24:34 2006 @@ -5,17 +5,19 @@ # $FreeBSD$ # -PORTNAME= cutemenus_-_crystal_svg +PORTNAME= cutemenus-crystalsvg PORTVERSION= 0.9.9.73 DISTVERSIONSUFFIX= -fx+fl+tb CATEGORIES= www +MASTER_SITE_SUBDIR=extensions/cutemenus_-_crystal_svg +DISTNAME= cutemenus_-_crystal_svg-${DISTVERSION}${DISTVERSIONSUFFIX} MAINTAINER= lapo@lapo.it COMMENT= An extension that adds cute icons to menus XPI_ID= {63df8e21-711c-4074-a257-b065cadc28d8} -XPI_FILES= chrome/cutemenus.jar chrome.manifest install.js install.rdf -XPI_DIRS= chrome +XPI_FILES= chrome/cutemenus.jar chrome.manifest install.js install.rdf +XPI_DIRS= chrome .include "../xpi-adblock/Makefile.xpi" .include <bsd.port.mk>
Responsible Changed From-To: freebsd-ports-bugs->sat Take
State Changed From-To: open->closed Committed, thanks!