Bug 96778 - [patch] lang/smarteiffel
Summary: [patch] lang/smarteiffel
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-04 16:00 UTC by Gabor Kovesdan
Modified: 2006-05-16 21:53 UTC (History)
1 user (show)

See Also:

Attachments
smarteiffel.diff (968 bytes, patch)
2006-05-04 16:00 UTC, Gabor Kovesdan 		no flags Details | Diff
smarteiffel.diff (833 bytes, patch)
2006-05-10 23:17 UTC, Gabor Kovesdan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kovesdan 2006-05-04 16:00:32 UTC 
- Respect CFLAGS and CXXFLAGS
- Bump PORTREVISION
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-05-04 16:04:08 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 berend 2006-05-04 20:42:07 UTC 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Edwin Groothuis <edwin@FreeBSD.org> writes:

> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.

Yes, looks useful.

- -- 
All the best,

Berend de Boer
(PGP public key: http://www.pobox.com/~berend/berend-public-key.txt)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFEWlkOIyuuaiRyjTYRAmYOAJ9x1sbMJQ+SFvZc584nc7jTYMuragCeIcsz
oSONhTBc2lcu3P+WwuTZY2c=
=M2Gt
-----END PGP SIGNATURE-----
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2006-05-05 02:23:37 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 4 Emanuel Haupt freebsd_committer freebsd_triage 2006-05-08 00:44:43 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Take.
Comment 5 Emanuel Haupt freebsd_committer freebsd_triage 2006-05-08 00:45:01 UTC 
State Changed
From-To: open->feedback

CFLAGS should always be respected, whether C(XX)FLAGS is defined or not. Could 
you please make the port also respect CC?
Comment 6 Gabor Kovesdan 2006-05-10 23:17:59 UTC 
I've tried to make it respect CC as well, but it is hardcoded in a very 
ugly way and I wasn't able to work around it. But I used unnecessary 
conditionals in the first patch. Here's the new one.

Regards,

Gabor Kovesdan
Comment 7 Emanuel Haupt freebsd_committer freebsd_triage 2006-05-12 10:47:30 UTC 
State Changed
From-To: feedback->open

Feedback received.
Comment 8 Emanuel Haupt freebsd_committer freebsd_triage 2006-05-16 21:53:45 UTC 
State Changed
From-To: open->closed

Committed, thanks!