- Update to 0.9.13 - Depend on freetype2 and fontforge I've run a few apps to test the new version without any trouble Announcement here: http://www.winehq.com/?announce=1.117 Fix: http://people.freebsd.org/~sat/diffs/wine.diff
Responsible Changed From-To: freebsd-ports-bugs->gerald Over to maintainer
State Changed From-To: open->feedback Hi Andrew, thanks for helping with this -- indeed I've a bit of a backlog right now and was just starting to work on the update. The one thing I'd like to avoid, if possible, is adding the FontForge dependency. This is in fact not a new dependency, rather upstream just add a new "exitcode=1" to the configure script. Could we just revert this one, via the patch below (as files/patches-configure)? Index: configure =================================================================== RCS file: /home/wine/wine/configure,v retrieving revision 1.808 diff -u -3 -p -r1.808 configure --- configure 23 May 2006 16:06:02 -0000 1.808 +++ configure 24 May 2006 22:15:49 -0000 @@ -21819,7 +21819,6 @@ then echo echo "*** Warning: FreeType or FontForge is missing." echo "*** Fonts will not be built. Dialog text may be invisible or unaligned." - exitcode=1 fi if test -z "$ALSALIBS" -a This does not actually change behavior from previous versions, and I've not got a single complaint about the previous behavior, which is why I'd like to give it a try (and not add this one dependency). FreeType is found on your average system much more than FontForge as far as I can tell, so I do not worry about that one as much. Also, the release announcement for the latest version of Wine just arrived in my inbox. If you'd like to take that one, that would be fine (but I'll leave the choice yours). Approved by: gerald (maintainer)
On 5/25/06, Gerald Pfeifer <gerald@freebsd.org> wrote: > The one thing I'd like to avoid, if possible, is adding the FontForge > dependency. This is in fact not a new dependency, rather upstream just > add a new "exitcode=3D1" to the configure script. Could we just revert > this one, via the patch below (as files/patches-configure)? I saw that, and fontforge might not be necessary. But I've been having fonts-related problems for the last few releases and depending on fontforge and freetype solved them all for me. I think missing fontforge is just preventing configure to do the right thing, but it would take more than delete the exitcode to fix it. Additionally, we would have to verify that fontforge really isn't used, which I come to doubt. So I suggest we live with this dependency until we have a better chance to investigate this or it is dropped officially. > Also, the release announcement for the latest version of Wine just arrive= d in > my inbox. If you'd like to take that one, that would be fine (but I'll l= eave > the choice yours). I'm already working on it. I'll post a new diff later. Thanks!
Here we go. Almost no plist/func changes: http://people.freebsd.org/~sat/diffs/wine0914.diff
State Changed From-To: feedback->open Thanks for the updates patch. I'm currently testing this.
On Thu, 25 May 2006, Andrew Pantyukhin wrote: > On 5/25/06, Gerald Pfeifer <gerald@freebsd.org> wrote: >> The one thing I'd like to avoid, if possible, is adding the FontForge >> dependency. This is in fact not a new dependency, rather upstream just >> add a new "exitcode=1" to the configure script. Could we just revert >> this one, via the patch below (as files/patches-configure)? > I saw that, and fontforge might not be necessary. But I've been > having fonts-related problems for the last few releases and > depending on fontforge and freetype solved them all for me. In the meantime I did various additional checks, and found that the list of installed files differs between the case where FontForge is installed and the one where it's not. It is really not used in the latter case. This means that users who have FontForge installed will get incorrect packaging lists in case we do not make FontForge a dependency. Of course we could work around this, via dynamic packaging lists, for example, but given your experience it's probably worth the cost of adding this as an extra dependency. > I'm already working on it. I'll post a new diff later. Thanks! I found two problems with this patchset during my testing a PREFIX different from /usr/local and have changes for both in testing right now. Gerald
On Tue, 30 May 2006, Gerald Pfeifer wrote: > Thanks! I found two problems with this patchset during my testing a > PREFIX different from /usr/local and have changes for both in testing > right now. In a nutshell, the two problems/solutions were: 1) I added -L${LOCALBASE}/lib to LDFLAGS so that it finds the FreeType libraries. 2) Avoid using DATADIR in pkg-plist, since the port itself does not honor this variable.
State Changed From-To: open->closed I applied your patch with few minor tweaks, mostly to get the build and pkg-plist with a non-default PREFIX working. Thanks a lot for the initial submission, the update, and the discussions. Without this, it probably would have taken another week at least to get the update going!