Bug 98229 - www/mod_musicindex needs -fPIC on amd64
Summary: www/mod_musicindex needs -fPIC on amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-31 17:50 UTC by Yuri Pankov
Modified: 2006-07-06 20:11 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Pankov 2006-05-31 17:50:13 UTC
www/mod_musicindex needs -fPIC added to CFLAGS to build correctly on amd64

Fix: 

CPPFLAGS=      -DHAS_MP3 -DHAS_OGG -DHAS_FLAC
-CFLAGS+=       -I${LOCALBASE}/include
+CFLAGS+=       -I${LOCALBASE}/include -fPIC

 #WANT_APACHE=  YES
 USE_GMAKE=     yes--w6FXzvJrXNgRjGMcgi16Ol53m2KBZxCZAzC4kFrjNClhqupi
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig       Wed May 31 20:44:09 2006
+++ Makefile    Wed May 31 20:43:58 2006
@@ -23,7 +23,7 @@
                FLAC.7:${PORTSDIR}/audio/flac
How-To-Repeat: cd /usr/ports/www/mod_musicindex ; make:

===>  Vulnerability check disabled, database not found
===>  Extracting for mod_musicindex-0.99.7_3
=> MD5 Checksum OK for libapache-mod-musicindex_0.99.7.tar.gz.
=> SHA256 Checksum OK for libapache-mod-musicindex_0.99.7.tar.gz.
===>  Patching for mod_musicindex-0.99.7_3
===>  Applying FreeBSD patches for mod_musicindex-0.99.7_3
===>   mod_musicindex-0.99.7_3 depends on file: /usr/local/sbin/apxs - found
===>   mod_musicindex-0.99.7_3 depends on executable: gmake - found
===>   mod_musicindex-0.99.7_3 depends on shared library: vorbis.3 - found
===>   mod_musicindex-0.99.7_3 depends on shared library: id3tag.0 - found
===>   mod_musicindex-0.99.7_3 depends on shared library: mad.2 - found
===>   mod_musicindex-0.99.7_3 depends on shared library: FLAC.7 - found
===>  Configuring for mod_musicindex-0.99.7_3
===>  Building for mod_musicindex-0.99.7_3
cc -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -I/usr/local/include/apache2  -O -g -pipe  -I/usr/local/include -Wall -pedantic  -o config.o -c config.c
cc -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -I/usr/local/include/apache2  -O -g -pipe  -I/usr/local/include -Wall -pedantic  -o html.o -c html.c
cc -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -I/usr/local/include/apache2  -O -g -pipe  -I/usr/local/include -Wall -pedantic  -o http.o -c http.c
cc -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -I/usr/local/include/apache2  -O -g -pipe  -I/usr/local/include -Wall -pedantic  -o inf.o -c inf.c
cc -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -I/usr/local/include/apache2  -O -g -pipe  -I/usr/local/include -Wall -pedantic  -o playlist.o -c playlist.c
cc -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -I/usr/local/include/apache2  -O -g -pipe  -I/usr/local/include -Wall -pedantic  -o mod_musicindex.o -c mod_musicindex.c
cc -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -I/usr/local/include/apache2  -O -g -pipe  -I/usr/local/include -Wall -pedantic  -o cache.o -c cache.c
cc -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -I/usr/local/include/apache2  -O -g -pipe  -I/usr/local/include -Wall -pedantic  -o playlist-mp3.o -c playlist-mp3.c
cc -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -I/usr/local/include/apache2  -O -g -pipe  -I/usr/local/include -Wall -pedantic  -o playlist-ogg.o -c playlist-ogg.c
cc -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -I/usr/local/include/apache2  -O -g -pipe  -I/usr/local/include -Wall -pedantic  -o playlist-flac.o -c playlist-flac.c
cc -shared -O -g -pipe  -I/usr/local/include -Wall -pedantic  -DHAS_MP3 -DHAS_OGG -DHAS_FLAC -DEAPI -L/usr/local/lib -lid3tag -lmad -lvorbis -lvorbisfile -lFLAC -o mod_musicindex.so config.o html.o http.o inf.o playlist.o mod_musicindex.o cache.o playlist-mp3.o playlist-ogg.o playlist-flac.o
/usr/bin/ld: config.o: relocation R_X86_64_32 can not be used when making a shared object; recompile with -fPIC
config.o: could not read symbols: Bad value
gmake: *** [mod_musicindex.so] Error 1
*** Error code 2

Stop in /usr/ports/www/mod_musicindex.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-05-31 17:52:15 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Tobias Roth 2006-06-12 11:15:00 UTC
I am working on an update to mod_musicindex, but it is not quite ready.
I assume the above patch is all right, though I can't test it due to
lack of amd64 hardware.

In the meantime, please test and commit as you please.

Thanks, Tobias
Comment 3 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-06-17 23:54:51 UTC
It builds OK w/o this patch on my amd64 tindy:

Description	7-HEAD-amd64	
System		FreeBSD 7 (.) updated on 2006-06-05 18:59:20	
Ports Tree	exp FPT updated on 2006-06-18 01:31:44

Description	6-STABLE-amd64 with myPT	
System		FreeBSD 6 (RELENG_6) updated on 2006-06-05 17:52:07	
Ports Tree	exp FPT updated on 2006-06-18 01:31:44

Description	5-STABLE-amd64 with myPT	
System		FreeBSD 5 (RELENG_5) updated on 2006-06-05 16:25:12	
Ports Tree	exp FPT updated on 2006-06-18 01:31:44

-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"

The heart is not a logical organ.
		-- Dr. Janet Wallace, "The Deadly Years", stardate

Comment 4 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-06-17 23:55:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

Track.
Comment 5 Yuri Pankov 2006-06-18 00:54:46 UTC
It's 100% reproducible here with today's -CURRENT/amd64 and recent ports
tree. Installed apache version - apache-2.0.58_1.

/etc/make.conf:

CFLAGS=-O -g -pipe
# added by use.perl 2006-06-12 06:41:06
PERL_VER=5.8.8
PERL_VERSION=5.8.8

-g is used to build GNOME with debugging symbols. Could it cause the
error?

/usr/bin/ld: config.o: relocation R_X86_64_32 can not be used when
making a shared object; recompile with -fPIC
config.o: could not read symbols: Bad value
Comment 6 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-06-18 11:08:46 UTC
On Sun, 18 Jun 2006 03:54:46 +0400
Yuri Pankov <yuri.pankov@gmail.com> wrote:

> It's 100% reproducible here with today's -CURRENT/amd64 and recent ports
> tree. Installed apache version - apache-2.0.58_1.
> 
> /etc/make.conf:
> 
> CFLAGS=-O -g -pipe
> # added by use.perl 2006-06-12 06:41:06
> PERL_VER=5.8.8
> PERL_VERSION=5.8.8
> 
> -g is used to build GNOME with debugging symbols. Could it cause the
> error?


It might; could you please try to build this port w/o it ?


-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"

BOFH excuse #433:
error: one bad user found in front of screen

Comment 7 Ion-Mihai " IOnut " Tetcu 2006-06-22 10:25:57 UTC
On Sun, 18 Jun 2006 13:08:46 +0300
Ion-Mihai "IOnut" Tetcu <itetcu@FreeBSD.org> wrote:

> On Sun, 18 Jun 2006 03:54:46 +0400
> Yuri Pankov <yuri.pankov@gmail.com> wrote:
> 
> > It's 100% reproducible here with today's -CURRENT/amd64 and recent ports
> > tree. Installed apache version - apache-2.0.58_1.
> > 
> > /etc/make.conf:
> > 
> > CFLAGS=-O -g -pipe
> > # added by use.perl 2006-06-12 06:41:06
> > PERL_VER=5.8.8
> > PERL_VERSION=5.8.8
> > 
> > -g is used to build GNOME with debugging symbols. Could it cause the
> > error?
> 
> It might; could you please try to build this port w/o it ?

Any news on this ?


-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"

Men of peace usually are [brave].
		-- Spock, "The Savage Curtain", stardate 5906.5
Comment 8 Yuri Pankov 2006-07-01 15:29:00 UTC
Ion-Mihai Tetcu wrote:
> On Sun, 18 Jun 2006 13:08:46 +0300
> Ion-Mihai "IOnut" Tetcu <itetcu@FreeBSD.org> wrote:
>
>   
>> On Sun, 18 Jun 2006 03:54:46 +0400
>> Yuri Pankov <yuri.pankov@gmail.com> wrote:
>>
>>     
>>> It's 100% reproducible here with today's -CURRENT/amd64 and recent ports
>>> tree. Installed apache version - apache-2.0.58_1.
>>>
>>> /etc/make.conf:
>>>
>>> CFLAGS=-O -g -pipe
>>> # added by use.perl 2006-06-12 06:41:06
>>> PERL_VER=5.8.8
>>> PERL_VERSION=5.8.8
>>>
>>> -g is used to build GNOME with debugging symbols. Could it cause the
>>> error?
>>>       
>> It might; could you please try to build this port w/o it ?
>>     
>
> Any news on this ?
>
>
>   
I'm very sorry for the delay.

Looks like CFLAGS in my make.conf has nothing to do with the error. I
think your tinderbox compiles mod_musicindex against apache13, which is
default, and I've no error with apache13. Problem exists only with apache2+.

--
Yuri
Comment 9 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-07-06 20:11:34 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!