In port ports/sysutils/syslog-ng it is impossible to change parameters of start syslog-ng. Fix: . %%RC_SUBR%% @@ -21,13 +23,14 @@ command=%%PREFIX%%/sbin/syslog-ng required_files=%%PREFIX%%/etc/syslog-ng/syslog-ng.conf -pidfile=/var/run/syslog.pid extra_commands=reload stop_postcmd=stop_postcmd load_rc_config $name : ${syslog_ng_enable:="NO"} +pidfile=${syslog_ng_pid:-"/var/run/syslog.pid"} +command_args="-p ${pidfile} ${syslog_ng_config}" stop_postcmd() { rm -f $pidfile--FkLZgOjHLt3ugkpWpB9lODppfllXQATRXzyH0AdCuBcX3OK7 Content-Type: text/plain; name="file.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="file.diff" --- files/syslog-ng.sh.in.orig Thu Jun 1 17:20:04 2006 +++ files/syslog-ng.sh.in Thu Jun 1 17:52:22 2006 @@ -12,6 +12,8 @@ # to enable this service: # #syslog_ng_enable="YES" +#syslog_ng_config="-u daemon" +#syslog_ng_pid="/var/run/syslog-ng.pid" #
State Changed From-To: open->feedback Awaiting maintainers feedback
Edwin, sorry for the delay here... Please go ahead and commit. Thanks, -Vince
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->itetcu I'll take it.
State Changed From-To: open->feedback Could you please make the script resamble more closely to the example in Porters Hanbook ch. 6.15; also does the extra_commands=reload work ? I don't see it implemented anywhere. Thnaks.
Remember, anything that gets patched into: http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/syslog-ng/files/ Must also now be patched into: http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/syslog-ng2/files/ itetcu@: "reload" works fine. It's part of rc.subr(4) and Syslog-NG 1.x and 2.x accept SIGHUP just fine as long as $pidfile is defined. All: As for the $pidfile change from static declaration to default-w-user-override-able, this is correct and proper. Many places run both native in-tree syslogd(8) for the system and syslog-ng(8) for special purposes, so they'll want to specify a specific PID. I would recommend that you please commit that change. Also, I can open a separate ticket for formality, or we can commit this little nit as well: diff -u /usr/ports/sysutils/syslog-ng/files/syslog-ng.sh.in syslog-ng.sh.in --- /usr/ports/sysutils/syslog-ng/files/syslog-ng.sh.in Wed Mar 29 16:20:19 2006 +++ syslog-ng.sh.in Fri Nov 3 20:32:59 2006 @@ -14,6 +14,8 @@ #syslog_ng_enable="YES" # +syslog_ng_purgeklog=${syslog_ng_purgeklog-"NO"} + . %%RC_SUBR%% name=syslog_ng @@ -23,6 +25,11 @@ required_files=%%PREFIX%%/etc/syslog-ng/syslog-ng.conf extra_commands=reload + +if checkyesno syslog_ng_purgeklog; then + start_precmd="echo \"Purging klog(9)\" && sysctl -w kern.msgbuf_clear=1 $start_precmd"; +fi + stop_postcmd=stop_postcmd load_rc_config $name ---- -- Brian A. Seklecki <bseklecki@collaborativefusion.com> Collaborative Fusion, Inc.
itetcu 2006-12-03 22:52:09 UTC FreeBSD ports repository Modified files: sysutils/syslog-ng/files syslog-ng.sh.in Log: - Allow user to change parameters of start syslog-ng via vars rc.d script [1] - Allow user to purge klog(9) via vars rc.d script [2] PR: ports/98287 [1] and [2] Submitted by: Pavel Volkov [1], Brian A. Seklecki [2] Revision Changes Path 1.2 +12 -2 ports/sysutils/syslog-ng/files/syslog-ng.sh.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!
State Changed From-To: closed->patched Un-close it waiting for syslog-ng2 maintianer's feedback.
Update approved for syslog-ng2 too cheers
Responsible Changed From-To: itetcu->freebsd-ports-bugs It is of no use to keep this PRs for myself, the way real life keeps being I have to use en unlikely half hour of free time to sleep :(
rafan 2007-03-19 06:28:09 UTC FreeBSD ports repository Modified files: sysutils/syslog-ng2 Makefile sysutils/syslog-ng2/files syslog-ng.sh.in Log: Merge rc script changes from syslog-ng port: - Allow user to change parameters of start syslog-ng via vars rc.d script [1] - Allow user to purge klog(9) via vars rc.d script [2] PR: ports/98287 [1] and [2] Submitted by: Pavel Volkov [1], Brian A. Seklecki [2] Approved by: Ivan Lago <ivan.lago at ifom-ieo-campus.it> (maintainer) Revision Changes Path 1.3 +1 -0 ports/sysutils/syslog-ng2/Makefile 1.2 +12 -2 ports/sysutils/syslog-ng2/files/syslog-ng.sh.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: patched->closed Committed to syslog-ng2.