Bug 98710 - [MAINTAINER] misc/e2fsprogs-libuuid: run selftest before install
Summary: [MAINTAINER] misc/e2fsprogs-libuuid: run selftest before install
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-08 17:00 UTC by Matthias Andree
Modified: 2006-06-09 23:20 UTC (History)
0 users

See Also:


Attachments
e2fsprogs-libuuid-1.39.patch (434 bytes, patch)
2006-06-08 17:00 UTC, Matthias Andree
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree 2006-06-08 17:00:36 UTC
Run self tests before installing the port or building the package.

Generated with FreeBSD Port Tools 0.77
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2006-06-09 20:32:31 UTC
State Changed
From-To: open->feedback

Would it be enough if only pointyhat was running the tests, and not the end 
users?  If so, you could consider using regression-test: target for this work. 
It's being run on pointyhat as part of the package builds. 


Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2006-06-09 20:32:31 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Track
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2006-06-09 23:15:40 UTC
State Changed
From-To: feedback->open

The selftest takes 0.76 CPU seconds on my vintage 300 MHz K6-2 machine, 
you can't even download the source in that time unless you're in the 
same LAN as a SourceForge mirror, let alone configure and build the 
package which takes 107 CPU seconds. So we're talking about a few bytes 
and 0.7% increase of build time. I think this is negligible. 

Since the upstream maintainer isn't using FreeBSD for development and 
I've had to patch away several regressions in e2fsprogs where this 
package was split from, I'd sleep better at night if we could run the 
selftest everywhere, particularly given the very low cost. 

Matthias Andree
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2006-06-09 23:20:15 UTC
State Changed
From-To: open->closed

Committed, thanks!