Bug 99018 - [patch] audio/gstreamer-plugins-faad: fix typo in COMMENT
Summary: [patch] audio/gstreamer-plugins-faad: fix typo in COMMENT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-16 11:20 UTC by Vasil Dimov
Modified: 2006-06-19 19:05 UTC (History)
1 user (show)

See Also:

Attachments
gstreamer-plugins-faad_typo.diff (469 bytes, patch)
2006-06-16 11:20 UTC, Vasil Dimov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vasil Dimov freebsd_committer freebsd_triage 2006-06-16 11:20:10 UTC 
I do not commit this with implicit approval because I am not 100% sure
if it is correct.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-06-16 11:24:10 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->multimedia

Over to maintainer
Comment 2 Vasil Dimov freebsd_committer freebsd_triage 2006-06-16 11:37:14 UTC 
On Fri, Jun 16, 2006 at 01:17:36PM +0300, Vasil Dimov wrote:
[...]
> RCS file: /home/pcvs/ports/audio/gstreamer-plugins-faad/Makefile,v
[...]
> -COMMENT=	Gstreamer MPEG-2 and MPEG-4 ACC decoder plugin
> +COMMENT=	Gstreamer MPEG-2 and MPEG-4 AAC decoder plugin
>  

Hmmz the value of this variable is overridden by
multimedia/gstreamer-plugins/Makefile.common:112:
COMMENT=        Gstreamer ${GST_PLUGIN} plugin

is this intentional?

-- 
Vasil Dimov
gro.DSBeerF@dv

Testing can show the presence of bugs, but not their absence.
                -- Edsger W. Dijkstra
Comment 3 Jeremy Messenger freebsd_committer freebsd_triage 2006-06-19 19:03:38 UTC 
State Changed
From-To: open->closed

It looks correct. As for gstreamer-plugins/Makefile.common:112, I am always 
in fan of static, so I prefer your first patch. If anyone in multimedia@ 
want to make any change is fine w/ me. 

Committed, thanks!