Bug 99636 - [MAINTAINER] security/denyhosts: [SUMMARIZE CHANGES]
Summary: [MAINTAINER] security/denyhosts: [SUMMARIZE CHANGES]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-30 08:50 UTC by Janos Mohacsi
Modified: 2006-07-03 12:12 UTC (History)
0 users

See Also:


Attachments
denyhosts-2.5.patch (1.78 KB, patch)
2006-06-30 08:50 UTC, Janos Mohacsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Janos Mohacsi 2006-06-30 08:50:31 UTC
Maintainer Update to security/denyhosts to version 2.5
Original packages Changes:

- ADMIN_EMAIL pref can now contain multiple email addresses delimited by a 
  comma (white space is optional).  eg. foo@bar.com, bar@foo.com, foobar@foo.com
- fixed bug in denyfileutil: 'timestamp' is now initialized properly
- daemon-control-dist: modified to work w/ non-default python versions.  You 
  must change the PYTHON_BIN and #!/bin/env/python references if appropriate.
- added a debug message when loading allowed-hosts fails.
- fixed bug when reporting suspicious login activity.

port/package changes:
- automatically installs/removes config files if necessary

Generated with FreeBSD Port Tools 0.63
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-06-30 08:50:39 UTC
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2006-06-30 08:50:46 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Mohacsi Janos 2006-06-30 09:07:21 UTC
Hi Edwin,
   	It was me who submitted the update.

Janos Mohacsi
Network Engineer, Research Associate, Head of Network Planning
NIIF/HUNGARNET, HUNGARY
Key 00F9AF98: 8645 1312 D249 471B DBAE  21A2 9F52 0D1F 00F9 AF98


On Fri, 30 Jun 2006, Edwin Groothuis wrote:

> Maintainer of security/denyhosts,
>
> Please note that PR ports/99636 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/99636
>
> -- 
> Edwin Groothuis
> edwin@FreeBSD.org
>
Comment 4 Renato Botelho freebsd_committer freebsd_triage 2006-06-30 12:24:38 UTC
Responsible Changed
From-To: freebsd-ports-bugs->garga

I'll take it.
Comment 5 Renato Botelho freebsd_committer freebsd_triage 2006-06-30 12:57:07 UTC
Dear maintainer,

I propose you the following patch, it has minor modifications, just install
a copy of denyhosts.cfg-dist into ${PREFIX}/etc, i think it's useful as a
easy reference to check. MAke the .cfg file comparison and install on
Makefile too, just on pkg-plist is not sufficient. And use PORTDOCS too.

Please, take a look and tell me if you approve.

----------------------------------------------------------------------- 
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/security/denyhosts/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile	19 May 2006 23:47:44 -0000	1.4
+++ Makefile	30 Jun 2006 11:54:07 -0000
@@ -6,11 +6,11 @@
 #
 
 PORTNAME=	denyhosts
-DISTVERSION=	2.4b
+PORTVERSION=	2.5
 CATEGORIES=	security
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	${PORTNAME}
-DISTNAME=	DenyHosts-${DISTVERSION}
+DISTNAME=	DenyHosts-${PORTVERSION}
 
 MAINTAINER=	janos.mohacsi@bsd.hu
 COMMENT=	Script to thwart ssh attacks
@@ -20,7 +20,7 @@
 
 USE_RC_SUBR=	denyhosts
 
-DOC_FILES=	CHANGELOG.txt LICENSE.txt README.txt
+PORTDOCS=	CHANGELOG.txt LICENSE.txt README.txt
 
 pre-configure:
 	@${REINPLACE_CMD} -e 's,%%PREFIX%%,${PREFIX},' \
@@ -29,11 +29,14 @@
 		${WRKSRC}/setup.py
 
 post-install:
-.ifndef(NOPORTDOCS)
+	${INSTALL_DATA} ${WRKSRC}/denyhosts.cfg-dist ${PREFIX}/etc
+	[ -f ${PREFIX}/etc/denyhosts.cfg ] || \
+		${INSTALL_DATA} ${WRKSRC}/denyhosts.cfg-dist ${PREFIX}/etc/denyhosts.cfg
+.if !defined(NOPORTDOCS)
 	@${MKDIR} ${DOCSDIR}
-.for file in ${DOC_FILES}
-	@${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR}
-.endfor
+. for f in ${PORTDOCS}
+	${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
+. endfor
 .endif
 	@${CAT} ${PKGMESSAGE}
 
Index: distinfo
===================================================================
RCS file: /home/pcvs/ports/security/denyhosts/distinfo,v
retrieving revision 1.3
diff -u -r1.3 distinfo
--- distinfo	19 May 2006 23:47:44 -0000	1.3
+++ distinfo	30 Jun 2006 11:54:07 -0000
@@ -1,3 +1,3 @@
-MD5 (DenyHosts-2.4b.tar.gz) = c60df73b29baeadffbbb1ef8f130dd8d
-SHA256 (DenyHosts-2.4b.tar.gz) = 851a050c6eb78618605eecdfae80a1ac412b2adc99160fb9c9d275f64858a7c1
-SIZE (DenyHosts-2.4b.tar.gz) = 42206
+MD5 (DenyHosts-2.5.tar.gz) = b33f0cdae6448ae559c5f22dbffe59f2
+SHA256 (DenyHosts-2.5.tar.gz) = 1efa1a977d0341bc5c94dbc652f86f3834e12013d7dc19a4f6e7b4b4c0242ed4
+SIZE (DenyHosts-2.5.tar.gz) = 42612
Index: pkg-plist
===================================================================
RCS file: /home/pcvs/ports/security/denyhosts/pkg-plist,v
retrieving revision 1.3
diff -u -r1.3 pkg-plist
--- pkg-plist	19 May 2006 23:47:44 -0000	1.3
+++ pkg-plist	30 Jun 2006 11:54:07 -0000
@@ -1,7 +1,10 @@
 bin/denyhosts.py
+@unexec if cmp -s %D/etc/denyhosts.cfg %D/etc/denyhosts.cfg-dist; then rm -f %D/etc/denyhosts.cfg; fi
+etc/denyhosts.cfg-dist
+@exec [ -f %B/denyhosts.cfg ] || cp -f %B/%f %B/denyhosts.cfg
+%%DATADIR%%/daemon-control-dist
 %%DATADIR%%/denyhosts.cfg-dist
 %%DATADIR%%/setup.py
-%%DATADIR%%/daemon-control-dist
 %%DATADIR%%/scripts/restricted_from_invalid.py
 %%DATADIR%%/scripts/restricted_from_passwd.py
 %%DATADIR%%/plugins/README.contrib
@@ -71,10 +74,6 @@
 %%PYTHON_SITELIBDIR%%/DenyHosts/restricted.py
 %%PYTHON_SITELIBDIR%%/DenyHosts/restricted.pyc
 %%PYTHON_SITELIBDIR%%/DenyHosts/restricted.pyo
-%%PORTDOCS%%%%DOCSDIR%%/CHANGELOG.txt
-%%PORTDOCS%%%%DOCSDIR%%/LICENSE.txt
-%%PORTDOCS%%%%DOCSDIR%%/README.txt
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
 @dirrm %%PYTHON_SITELIBDIR%%/DenyHosts
 @dirrm %%DATADIR%%/scripts
 @dirrm %%DATADIR%%/plugins
----------------------------------------------------------------------- 

-- 
Renato Botelho <garga @ FreeBSD.org>
               <freebsd @ galle.com.br>
GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc

Science and religion are in full accord but
science and faith are in complete discord.
Comment 6 Mohacsi Janos 2006-06-30 17:56:36 UTC
I forgot installing the .cfg file. Thanks for the improvement! PORTDOCS is 
something new that I learnt now. Thanks again.

Regards,

Janos Mohacsi
Network Engineer, Research Associate, Head of Network Planning
NIIF/HUNGARNET, HUNGARY
Key 00F9AF98: 8645 1312 D249 471B DBAE  21A2 9F52 0D1F 00F9 AF98


On Fri, 30 Jun 2006, Renato Botelho wrote:

> Dear maintainer,
>
> I propose you the following patch, it has minor modifications, just install
> a copy of denyhosts.cfg-dist into ${PREFIX}/etc, i think it's useful as a
> easy reference to check. MAke the .cfg file comparison and install on
> Makefile too, just on pkg-plist is not sufficient. And use PORTDOCS too.
>
> Please, take a look and tell me if you approve.
>
> -----------------------------------------------------------------------
> Index: Makefile
> ===================================================================
> RCS file: /home/pcvs/ports/security/denyhosts/Makefile,v
> retrieving revision 1.4
> diff -u -r1.4 Makefile
> --- Makefile	19 May 2006 23:47:44 -0000	1.4
> +++ Makefile	30 Jun 2006 11:54:07 -0000
> @@ -6,11 +6,11 @@
> #
>
> PORTNAME=	denyhosts
> -DISTVERSION=	2.4b
> +PORTVERSION=	2.5
> CATEGORIES=	security
> MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
> MASTER_SITE_SUBDIR=	${PORTNAME}
> -DISTNAME=	DenyHosts-${DISTVERSION}
> +DISTNAME=	DenyHosts-${PORTVERSION}
>
> MAINTAINER=	janos.mohacsi@bsd.hu
> COMMENT=	Script to thwart ssh attacks
> @@ -20,7 +20,7 @@
>
> USE_RC_SUBR=	denyhosts
>
> -DOC_FILES=	CHANGELOG.txt LICENSE.txt README.txt
> +PORTDOCS=	CHANGELOG.txt LICENSE.txt README.txt
>
> pre-configure:
> 	@${REINPLACE_CMD} -e 's,%%PREFIX%%,${PREFIX},' \
> @@ -29,11 +29,14 @@
> 		${WRKSRC}/setup.py
>
> post-install:
> -.ifndef(NOPORTDOCS)
> +	${INSTALL_DATA} ${WRKSRC}/denyhosts.cfg-dist ${PREFIX}/etc
> +	[ -f ${PREFIX}/etc/denyhosts.cfg ] || \
> +		${INSTALL_DATA} ${WRKSRC}/denyhosts.cfg-dist ${PREFIX}/etc/denyhosts.cfg
> +.if !defined(NOPORTDOCS)
> 	@${MKDIR} ${DOCSDIR}
> -.for file in ${DOC_FILES}
> -	@${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR}
> -.endfor
> +. for f in ${PORTDOCS}
> +	${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
> +. endfor
> .endif
> 	@${CAT} ${PKGMESSAGE}
>
> Index: distinfo
> ===================================================================
> RCS file: /home/pcvs/ports/security/denyhosts/distinfo,v
> retrieving revision 1.3
> diff -u -r1.3 distinfo
> --- distinfo	19 May 2006 23:47:44 -0000	1.3
> +++ distinfo	30 Jun 2006 11:54:07 -0000
> @@ -1,3 +1,3 @@
> -MD5 (DenyHosts-2.4b.tar.gz) = c60df73b29baeadffbbb1ef8f130dd8d
> -SHA256 (DenyHosts-2.4b.tar.gz) = 851a050c6eb78618605eecdfae80a1ac412b2adc99160fb9c9d275f64858a7c1
> -SIZE (DenyHosts-2.4b.tar.gz) = 42206
> +MD5 (DenyHosts-2.5.tar.gz) = b33f0cdae6448ae559c5f22dbffe59f2
> +SHA256 (DenyHosts-2.5.tar.gz) = 1efa1a977d0341bc5c94dbc652f86f3834e12013d7dc19a4f6e7b4b4c0242ed4
> +SIZE (DenyHosts-2.5.tar.gz) = 42612
> Index: pkg-plist
> ===================================================================
> RCS file: /home/pcvs/ports/security/denyhosts/pkg-plist,v
> retrieving revision 1.3
> diff -u -r1.3 pkg-plist
> --- pkg-plist	19 May 2006 23:47:44 -0000	1.3
> +++ pkg-plist	30 Jun 2006 11:54:07 -0000
> @@ -1,7 +1,10 @@
> bin/denyhosts.py
> +@unexec if cmp -s %D/etc/denyhosts.cfg %D/etc/denyhosts.cfg-dist; then rm -f %D/etc/denyhosts.cfg; fi
> +etc/denyhosts.cfg-dist
> +@exec [ -f %B/denyhosts.cfg ] || cp -f %B/%f %B/denyhosts.cfg
> +%%DATADIR%%/daemon-control-dist
> %%DATADIR%%/denyhosts.cfg-dist
> %%DATADIR%%/setup.py
> -%%DATADIR%%/daemon-control-dist
> %%DATADIR%%/scripts/restricted_from_invalid.py
> %%DATADIR%%/scripts/restricted_from_passwd.py
> %%DATADIR%%/plugins/README.contrib
> @@ -71,10 +74,6 @@
> %%PYTHON_SITELIBDIR%%/DenyHosts/restricted.py
> %%PYTHON_SITELIBDIR%%/DenyHosts/restricted.pyc
> %%PYTHON_SITELIBDIR%%/DenyHosts/restricted.pyo
> -%%PORTDOCS%%%%DOCSDIR%%/CHANGELOG.txt
> -%%PORTDOCS%%%%DOCSDIR%%/LICENSE.txt
> -%%PORTDOCS%%%%DOCSDIR%%/README.txt
> -%%PORTDOCS%%@dirrm %%DOCSDIR%%
> @dirrm %%PYTHON_SITELIBDIR%%/DenyHosts
> @dirrm %%DATADIR%%/scripts
> @dirrm %%DATADIR%%/plugins
> -----------------------------------------------------------------------
>
> -- 
> Renato Botelho <garga @ FreeBSD.org>
>               <freebsd @ galle.com.br>
> GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc
>
> Science and religion are in full accord but
> science and faith are in complete discord.
>
Comment 7 Renato Botelho freebsd_committer freebsd_triage 2006-07-03 12:12:47 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!