Bug 263101

Summary: devel/ncurses: patch-configure not needed anymore to remove unnecessary CFLAGS
Product: Ports & Packages Reporter: Daniel Eisele <daniel_eisele>
Component: Individual Port(s)Assignee: Muhammad Moinur Rahman <bofh>
Status: New ---    
Severity: Affects Only Me CC: arved
Priority: --- Flags: bugzilla: maintainer-feedback? (swills)
Version: Latest   
Hardware: Any   
OS: Any   

Description Daniel Eisele 2022-04-06 20:30:45 UTC 
The patch for the configure script (re)introduced in bug #234049 isn't needed
anymore because now the function CF_POSIX_VISIBLE (included from aclocal.m4)
prevents the problematic CFLAGS from being added.

I also tested this to be sure. The diff at the end shows no difference with or without the patch:
# cd /usr/ports/devel/ncurses/
# make
[...]
# cp -r work work_patch
# make clean
===>  Cleaning for ncurses-6.3
# mv files/patch-configure .
# make
[...]
# cp -r work work_no_patch
# ls work_patch/stage/usr/local/libdata/pkgconfig/
form.pc         ncurses++.pc    ncursesw.pc     tinfo.pc
menu.pc         ncurses.pc      panel.pc
# diff -r work_patch/stage/usr/local/libdata/pkgconfig/ work_no_patch/stage/usr/local/libdata/pkgconfig/
#
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2023-04-11 20:20:29 UTC 
Maintainer reset.