Bug 207042 - security/keepassx2: Assertion failure in salsa20.c
Summary: security/keepassx2: Assertion failure in salsa20.c
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: regression
: 207235 (view as bug list)
Depends on: 207107
Blocks:
  Show dependency tree / graph
 
Reported: 2016-02-09 04:16 UTC by mark.perrego
Modified: 2016-02-16 02:56 UTC (History)
6 users (show)

See Also:
bugzilla: maintainer-feedback? (eric)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mark.perrego 2016-02-09 04:16:00 UTC 
Attempting to run keepassx2 yields the following error:

% keepassx
Ohhhh jeeee: Assertion `ctx->unused < 64' failed (salsa20.c:400:salsa20_do_encrypt_stream)
Abort

I suspect it is due to the changes in ports r408514, but I don't know if those changes are bad, or if keepassx2 needs to be updated to match.

% uname -r
10.2-RELEASE-p9
Comment 1 Thibault Payet 2016-02-10 10:45:01 UTC 
I upgraded keepassx2 to version 2.0.2 but I get the same error
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2016-02-10 20:44:56 UTC 
This happens to me as well.  I too believe the recent update to security/libgcrypt is at fault (see bug #206919).  If I downgrade to libgcrypt-1.6.4_3 keepassx2 starts again.
Comment 3 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-02-10 21:42:42 UTC 
Tonight I will fix this issue. In addition libgcrypt 1.6.5 was released.

Thanks for reporting!
Comment 4 Jason Unovitch freebsd_committer freebsd_triage 2016-02-13 23:01:48 UTC 
Thanks for the report. Can you try the security/libgcrypt patch in bug 207107 and report back if that fixes the issue?

Carlos, I'll assign this to you to follow through on.
Comment 5 mark.perrego 2016-02-14 01:34:59 UTC 
The upgraded libgcrypt does not appear to fix this for me. I did the following as root, from /usr/ports:

# patch -i ~mark/libgcrypt.diff -C
# patch -i ~mark/libgcrypt.diff
# cd security/libgcrypt
# make deinstall ; make clean ; make
# make install
# cd ../../
# cd security/keepassx2/
# make deinstall ; make clean ; make reinstall

I get the same error when I try to start keepassx2.
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2016-02-14 01:44:59 UTC 
Same here.
Comment 7 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-02-15 23:22:11 UTC 
Please, can you try with this patch attached?

https://bz-attachments.freebsd.org/attachment.cgi?id=167055&action=diff&format=raw&headers=1
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2016-02-16 00:40:55 UTC 
(In reply to Carlos J. Puga Medina from comment #7)
Tried it and it works :)
Comment 9 Jason Unovitch freebsd_committer freebsd_triage 2016-02-16 01:07:00 UTC 
(In reply to Tobias Kortkamp from comment #8)
Tobias, thanks for testing.  We'll get this in ASAP.

I'll tag this as a 'regression' but there's no patch requirement for security/keepassx2 in this PR so I won't add those keywords.
Comment 10 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-02-16 02:24:29 UTC 
*** Bug 207235 has been marked as a duplicate of this bug. ***
Comment 11 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-02-16 02:55:46 UTC 
This issue was fixed by bug 207107.