Bug 266487

Summary: [PATCH] net/srelay: should not install srelay.conf.sample as srelay.conf
Product: Ports & Packages Reporter: Matt Jacobson <mhjacobson>
Component: Individual Port(s)Assignee: Bernhard Froehlich <decke>
Status: New ---    
Severity: Affects Many People CC: mhjacobson
Priority: --- Flags: bugzilla: maintainer-feedback? (decke)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch for PR 266487 none

Description Matt Jacobson 2022-09-18 21:27:42 UTC
The net/srelay port installs the project's sample configuration file as both srelay.conf.sample and srelay.conf.

The sample config file contains settings that are not meant for default installation but rather as a demonstration of the configuration capabilities.  For instance:

# rest of any FQDN (and IPv6) destination should go 192.168.1.5 socks.
*				any	192.168.1.5	1080%                                                                                                                                               

This assumes the existence of a relay proxy at 192.168.1.5.

This is extra confusing because the Web documentation for srelay (at <https://socks-relay.sourceforge.io/> and <https://socks-relay.sourceforge.io/samples.html>) suggest that the default configuration uses no relay and is equivalent to

0.0.0.0    any

I suggest that the sample config file be installed only to etc/srelay.conf.sample but not to etc/srelay.conf .
Comment 1 Matt Jacobson 2022-10-27 03:25:42 UTC
Created attachment 237671 [details]
patch for PR 266487