Bug 103913 - [maintainer-update] ports sysutils/nagios-statd
Summary: [maintainer-update] ports sysutils/nagios-statd
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-02 19:00 UTC by Jim Shewmaker
Modified: 2006-10-02 20:40 UTC (History)
1 user (show)

See Also:


Attachments
nagiosstatd.patch (3.87 KB, patch)
2006-10-02 19:00 UTC, Jim Shewmaker
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Shewmaker 2006-10-02 19:00:32 UTC
	-Fix startup for rc.subr
	-Update to 3.12 (3.11 unfetchable)

Fix: superscedes ports/103497 (fixed bad patch)
Comment 1 Boris Samorodov freebsd_committer freebsd_triage 2006-10-02 19:31:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bsam

Take.
Comment 2 Boris B.Samorodov 2006-10-02 20:15:26 UTC
Thanks for taking care of the port.

However, did you check your patch? It applies cleanly but produces a
wrong pkg-plist. Look at
http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/nagios-statd/pkg-plist?rev=1.1&content-type=text/x-cvsweb-markup
This file has four lines and you add one. Hence the resulting
pkg-plist is bad.

And finally, the ports building system deals with USE_RC_SUBR files
without the need to add those files to pkg-plist.

I created a good pkg-plist now, but next time please make sure to test
your patches and provide a unified diffs. The best way is:
- update your port;
- use anonymous cvs access to checkout the port;
- copy new (overwrite an old ones) files to that directory;
- use command "cvs diff -uN > ../`basename ${PWD}`.diff" to create a
  unified diffs agains current port version.

WBR
-- 
bsam
Comment 3 dfilter service freebsd_committer freebsd_triage 2006-10-02 20:35:54 UTC
bsam        2006-10-02 19:35:43 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/nagios-statd Makefile distinfo pkg-plist 
  Added files:
    sysutils/nagios-statd/files nagiosstatd.sh.in 
  Removed files:
    sysutils/nagios-statd/files nagios-statd.sh.sample 
  Log:
  - fix startup for rc.subr;  [1]
  - update to 3.12;           [1]
  - remove etc/rc.d/nagiosstatd from pkg-plist as USE_RC_SUBR deals itself
    with those files;
  - remove etc/rc.d/nagios-statd.sh.sample from pkg-plist (forgotten by
    the submitter).
  
  PR:             103913  [1]
  Submitted by:   Jim Shewmaker <jims at bluenotch.com> (maintainer)  [1]
  
  Revision  Changes    Path
  1.5       +2 -2      ports/sysutils/nagios-statd/Makefile
  1.6       +3 -3      ports/sysutils/nagios-statd/distinfo
  1.3       +0 -21     ports/sysutils/nagios-statd/files/nagios-statd.sh.sample (dead)
  1.1       +35 -0     ports/sysutils/nagios-statd/files/nagiosstatd.sh.in (new)
  1.2       +1 -2      ports/sysutils/nagios-statd/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Boris Samorodov freebsd_committer freebsd_triage 2006-10-02 20:36:29 UTC
State Changed
From-To: open->closed

Committed with some changes. Thanks!