I'd like to propose a patch for ppp(8) which allows to change the behaviour of keeping port id unique. That maybe useful in case of using external packages, e.g. when using poptop (net/poptop), ppp(8) doesn't define NAS-Port-Id in RADIUS query. And it's not possible to do anything about it by changing ppp.conf, etc. There's one more reason why this patch may be useful. Devices by such vendors as Cisco, DLink and others define NAS-Port-Id as line number, which can be used then to drop the user from the line. However, it's not possible to do the same thing for VPN (PPPoE, PPTP) on FreeBSD. This patch allows to change the way of NAS-Port-Id gets defined by ppp(8). It adds a new option for ppp.conf: set rad_port_id. Possible values are: * set rad_port_id pid PID of the corresponding tunnel. Very nice to for dropping the line using kill(1) (or kill(2) if you want) * set rad_port_id tunnum tun(4) interface number * set rad_port_id ifnum index of the interface as of returned by if_nametoindex(3) * set rad_port_id default keeps the default behavior (i.e. the way ppp(8) works without this patch). Could be useful if the default behavior suits user or to keep ppp(8) compatible with legacy software. This is used in case when rad_port_id is not defined.
novel 2007-05-25 13:45:49 UTC FreeBSD src repository (ports committer) Modified files: usr.sbin/ppp command.c ppp.8.m4 radius.c radius.h Log: Add a new option for ppp.conf: rad_port_id. It allows to change the way of what ppp submits to the RADIUS server as NAS-Port-Id. Possible options are: the PID of the process owning the corresponding interface, tun(4) interface number, interface index (as it would get returned by if_nametoindex(3)), or it's possible to keep the default behavior. Check the ppp(8) manual page for details. PR: bin/112764 Submitted by: novel (myself) Reviewed by: flz Approved by: flz MFC after: 1 month Revision Changes Path 1.307 +27 -1 src/usr.sbin/ppp/command.c 1.326 +20 -1 src/usr.sbin/ppp/ppp.8.m4 1.54 +27 -10 src/usr.sbin/ppp/radius.c 1.22 +6 -0 src/usr.sbin/ppp/radius.h _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Responsible Changed From-To: freebsd-bugs->novel I will take it.
State Changed From-To: open->patched Awaiting MFC.
novel 2007-07-11 10:49:06 UTC FreeBSD src repository (ports committer) Modified files: (Branch: RELENG_6) usr.sbin/ppp command.c ppp.8.m4 radius.c radius.h Log: MFC command.c 1.307, radius.h 1.22, radius.c 1.54, ppp.8.m4 1.326: Add a new option for ppp.conf: rad_port_id. It allows to change the way of what ppp submits to the RADIUS server as NAS-Port-Id. Possible options are: the PID of the process owning the corresponding interface, tun(4) interface number, interface index (as it would get returned by if_nametoindex(3)), or it's possible to keep the default behavior. Check the ppp(8) manual page for details. MFC ppp.8.m4 1.327: Cleanup after previous commit. PR: bin/112764 Submitted by: novel (myself) Approved by: flz Revision Changes Path 1.305.2.1 +27 -1 src/usr.sbin/ppp/command.c 1.322.2.1 +21 -0 src/usr.sbin/ppp/ppp.8.m4 1.52.2.2 +27 -10 src/usr.sbin/ppp/radius.c 1.21.2.1 +6 -0 src/usr.sbin/ppp/radius.h _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: patched->closed MFCed into RELENG_6, so close the PR.