I update sxml version from 1.0.4 to 1.0.5. The wyvern-2.2.10 in www/wyvern depends on sxml-1.0.5.
Hi Kouichi, could you resend this one as a unified diff, too? Thanks, Stefan
State Changed From-To: open->feedback Awaiting submitter's feedback.
Responsible Changed From-To: freebsd-ports-bugs->stefan Take.
Hi Stefan, Sorry, I forgot to resend the patch. I resend it in unified diff format. Best regards. -- Kouichi ABE (WALL) kouichi@MysticWALL.COM http://www.MysticWALL.COM/ 4196 185C B814 8F96 D170 B492 71A8 1B2B B9D5 5CF5
Hi Kouichi, there are still a few issues with this update: - You removed USE_LDCONFIG, but the port installs shared libraries. When installing shared libraries, USE_LDCONFIG is usually desired. - You're setting PREFIX to LOCALBASE. This is extremely discouraged. The port should install to the PREFIX defined by the user/system. - The patch files/patch-sxmlrpc.c fails to apply with the new version. - I'm not sure if NO_MTREE is really needed here. Could you look at these and send me another update? Thanks and best regards, Stefan
Hi Stefan, On Sat, Oct 06, 2007 at 10:47:36AM +0000, Stefan Walter wrote > > - You removed USE_LDCONFIG, but the port installs shared libraries. When > installing shared libraries, USE_LDCONFIG is usually desired. > > - You're setting PREFIX to LOCALBASE. This is extremely discouraged. The > port should install to the PREFIX defined by the user/system. > > - I'm not sure if NO_MTREE is really needed here. Sorry, I made a mistake to modify the sxml-port. > - The patch files/patch-sxmlrpc.c fails to apply with the new version. The patch is alredy included in the sxml-1.0.5. I forgot to use the option '-N' for the diff command. I resend new patch in unified diff format. Best regards. -- Kouichi ABE (WALL) kouichi@MysticWALL.COM http://www.MysticWALL.COM/ 4196 185C B814 8F96 D170 B492 71A8 1B2B B9D5 5CF5
stefan 2007-10-06 11:23:52 UTC FreeBSD ports repository Modified files: textproc/sxml Makefile distinfo Removed files: textproc/sxml/files patch-sxmlrpc.c Log: Update to 1.0.5. PR: 116807 Submitted by: maintainer Revision Changes Path 1.2 +1 -1 ports/textproc/sxml/Makefile 1.2 +3 -3 ports/textproc/sxml/distinfo 1.2 +0 -23 ports/textproc/sxml/files/patch-sxmlrpc.c (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks!