Example fstab: /dev/ad3s1g /dsk01 ufs rw 1 2 [...] /dsk01 /stable5/dsk01 nullfs rw,noauto 0 0 # dump 0f /dev/null /dsk01 dump: unknown filesystem /dsk01 # How-To-Repeat: See above
Still there in 7.1 and there's a patch... ping?
In message <1BB65751E91EA64EA8436124B779A8BC3FA05F1EA2@IRVEXCHCCR01.corp.ad. bro adcom.com>, "Stephen Hurd" writes: > Still there in 7.1 and there's a patch... ping? No one has picked this PR up. As I'm a ports committer, not a src committer, I'll need to find someone to champion this for us for find someone to mentor me in the src tree. -- Cheers, Cy Schubert <Cy.Schubert@komquats.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org e**(i*pi)+1=0
Responsible Changed From-To: freebsd-bugs->cy-bugs kib has given me approval to commit this.
Responsible Changed From-To: cy-bugs->cy Fix typo as to my id from from cy-bugs to cy.
State Changed From-To: open->closed Committed with the approval of kib.
Author: cy (ports committer) Date: Mon Mar 2 03:08:46 2009 New Revision: 189267 URL: http://svn.freebsd.org/changeset/base/189267 Log: Verify that the filesystem being referenced in fstab is indeed a UFS filesystem. This avoids confusion with nullfs and unionfs filesystems which reference the root of a UFS filesystem as a target. PR: 116849 Approved by: kib Modified: head/sbin/dump/optr.c Modified: head/sbin/dump/optr.c ============================================================================== --- head/sbin/dump/optr.c Mon Mar 2 02:51:52 2009 (r189266) +++ head/sbin/dump/optr.c Mon Mar 2 03:08:46 2009 (r189267) @@ -318,9 +318,10 @@ dump_getfstab(void) return; } while ((fs = getfsent()) != NULL) { - if (strcmp(fs->fs_type, FSTAB_RW) && + if ((strcmp(fs->fs_type, FSTAB_RW) && strcmp(fs->fs_type, FSTAB_RO) && - strcmp(fs->fs_type, FSTAB_RQ)) + strcmp(fs->fs_type, FSTAB_RQ)) || + strcmp(fs->fs_vfstype, "ufs")) continue; fs = allocfsent(fs); if ((pf = (struct pfstab *)malloc(sizeof (*pf))) == NULL) _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
In message <1BB65751E91EA64EA8436124B779A8BC3FA05F1EA2@IRVEXCHCCR01.corp.ad. bro adcom.com>, "Stephen Hurd" writes: > Still there in 7.1 and there's a patch... ping? Hi Stephen, I've committed the patch to head (8.0-CURRENT) with the permission of kib@. I expect it to mature there for a while before it's merged into stable/7. Thanks for reminding us of the patch. Even though I've had it running on my systems since October 2007 and as I use an automated patch application script during my build process here at home and at work, I forgot about it (that's how well my automated patch script works -- fire and forget kind of thing). Anyhow, it's in. -- Cheers, Cy Schubert <Cy.Schubert@komquats.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org e**(i*pi)+1=0