7-Stable/sys/modules/xfs fails to make from world Been like that a few days (while my slow host made world) as: It's now Thu Jan 3 12:54:35 CET 2008, & from CTM delta dates of reception (& Yes acknowledging ctm is Push whereas cvsup is Pull, so a delay of maybe 12/24 hours). Bad between src-7.0075 & src-7.0077. Dec 30 12:12 /pub/FreeBSD/development/CTM/src-7/src-7.0075.gz Jan 1 10:52 /pub/FreeBSD/development/CTM/src-7/src-7.0076.gz Jan 2 08:49 /pub/FreeBSD/development/CTM/src-7/src-7.0077.gz With a src/ based on src-7.0075 cd /usr/src ; make world # ... ===> sys/modules/xfs (depend) @ -> /usr/src/sys machine -> /usr/src/sys/i386/include awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -p awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -q awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -h make: don't know how to make xfsrtstubs.c. Stop *** Error code 2 Stop in /usr/src/sys/modules. find . -name xfsrtstubs.c # Nothing # UPDATE ... ctm -v /pub/FreeBSD/development/CTM/src-7/src-7.0.gz cd /sys/modules/xfs ; make clean ; make # Still Fails # Also fails on another 7.0-PRERELEASE host (though that hasnt gone through # the rigour of a make world. Fix: This patch & follow up at: http://berklix.com/~jhs/src/bsd/fixes/freebsd/src/gen/sys/modules/xfs/Makefile.REL=ALL.diff--FBe9HbLK3gaMfcMxksq3GJvUkV0o8BWFYbFhYLRbLWzyjHEs Content-Type: text/plain; name="file.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="file.diff" *** 7.0-PRERELEASE-src-7.0077/src/sys/modules/xfs/Makefile.o Thu Jan 3 12:38:06 2008 .--- new/src/sys/modules/xfs/Makefile Thu Jan 3 12:43:32 2008 *************** *** 54,62 **** xfs_iget.c \ xfs_attr_leaf.c \ xfs_attr.c \ - xfsrtstubs.c \ - xfsquotasstubs.c \ - xfsdmapistubs.c \ xfs_dmops.c \ xfs_qmops.c \ xfs_mountops.c \ --- 54,59 ---- *************** *** 81,86 **** --- 78,87 ---- kmem.c \ kdb.c + # xfsrtstubs.c \ + # xfsquotasstubs.c \ + # xfsdmapistubs.c \ + SRCS+= opt_ddb.h .include <bsd.kmod.mk> How-To-Repeat: make world on stable-7
Responsible Changed From-To: freebsd-bugs->freebsd-fs Over to maintainer(s).
There are actually zero-byte files in src/sys/gnu/fs/xfs/FreeBSD by that name. Perhaps CTM doesn't handle creating empty files? -- John Baldwin
Responsible Changed From-To: freebsd-fs->kan I'll look at this.
Author: kan Date: Mon May 18 17:20:24 2009 New Revision: 192314 URL: http://svn.freebsd.org/changeset/base/192314 Log: Remove empty files and do nto try to build them. Apparently, they are problematic for CTF users. PR: 119298 Submitted by: Julian H. Stacey Deleted: head/sys/gnu/fs/xfs/FreeBSD/xfsdmapistubs.c head/sys/gnu/fs/xfs/FreeBSD/xfsquotasstubs.c head/sys/gnu/fs/xfs/FreeBSD/xfsrtstubs.c Modified: head/sys/modules/xfs/Makefile Modified: head/sys/modules/xfs/Makefile ============================================================================== --- head/sys/modules/xfs/Makefile Mon May 18 17:18:40 2009 (r192313) +++ head/sys/modules/xfs/Makefile Mon May 18 17:20:24 2009 (r192314) @@ -54,9 +54,6 @@ SRCS = vnode_if.h \ xfs_iget.c \ xfs_attr_leaf.c \ xfs_attr.c \ - xfsrtstubs.c \ - xfsquotasstubs.c \ - xfsdmapistubs.c \ xfs_dmops.c \ xfs_qmops.c \ xfs_mountops.c \ _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
On Mon, 18 May 2009 17:30:03 GMT John Baldwin <jhb@FreeBSD.org> wrote: > The following reply was made to PR kern/119298; it has been noted by > GNATS. > > From: John Baldwin <jhb@FreeBSD.org> > To: bug-followup@freebsd.org, > jhs@berklix.org > Cc: > Subject: Re: kern/119298: [xfs] [patch] 7-Stable/sys/modules/xfs > fails to make from world Date: Mon, 18 May 2009 11:16:13 -0400 > > There are actually zero-byte files in src/sys/gnu/fs/xfs/FreeBSD by > that name. Perhaps CTM doesn't handle creating empty files? > > -- > John Baldwin Exactly my suspicion and this is why I removed empty files with this change. -- Alexander Kabaev
State Changed From-To: open->patched THis is fixed in head and 8.x, mark patched pending MFC to 7.
State Changed From-To: patched->closed MFCed/fixed by now or it will never be MFCed