The current version of msntp (v1.6, October 2000) does not allow host name arguments that begin with a digit. It does this in internet.c by testing the first character of the argument string. If it is a digit, it assumes the string is dotted quad and uses gethostbyaddr(3) for look up. If otherwise, it will use gethostbyname(3). This fails legal host names as defined by RFC-1133. Fix: Since gethostbyname(3) already handles dotted quad strings as arguments, simply remove the previously mentioned conditional code in internet.c. Please see the included patch. I contacted the original author of msntp and verified that he no longer maintains nor knows of any current maintainer for msntp. Would it be possible to include the following patch in the net/msntp port? I ask because msntp is the ntp server used by m0n0wall, the FreeBSD based firewall project at http://m0n0.ch/wall/. It is very popular and this bug has bitten there. As usual, I can not thank you enough for all your time and effort. -virgil How-To-Repeat: Use msntp with a legitimate host name that begins with a digit. moose[879] msntp 0.north-america.pool.ntp.org msntp: invalid IP number 0.north-america.pool.ntp.org
Responsible Changed From-To: freebsd-ports-bugs->beech I'll take it
beech 2008-02-22 19:39:27 UTC FreeBSD ports repository Modified files: net/msntp Makefile Added files: net/msntp/files patch-internet.c Removed files: net/msntp pkg-plist Log: - Fix with a legitimate host name that begins with a digit. - Makefile cleanup - Bump portrevision PR: ports/120957 Submitted by: Virgil Champlin <champlin@stupidog.org> Revision Changes Path 1.3 +6 -4 ports/net/msntp/Makefile 1.1 +22 -0 ports/net/msntp/files/patch-internet.c (new) 1.3 +0 -4 ports/net/msntp/pkg-plist (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, Thanks!