Bug 125607 - [PATCH] x11/xscreensaver-gnome: pam option is broken
Summary: [PATCH] x11/xscreensaver-gnome: pam option is broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-14 17:10 UTC by mwisnicki+freebsd
Modified: 2008-07-19 05:10 UTC (History)
1 user (show)

See Also:


Attachments
xscreensaver-gnome-5.05_1.patch (1.26 KB, patch)
2008-07-14 17:10 UTC, mwisnicki+freebsd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mwisnicki+freebsd 2008-07-14 17:10:02 UTC
There is an obvious mistake in WITH_PAM case, which in addition to disabling
pam support causes plist breakage.

While there, enable PAM by default. PLEASE do not reject this unless you have
a good technical reason to do so. PAM is a stable and standard component of
FreeBSD base system since years. It is unconditionally enabled in x11/gdm.

Also, remove kerberos option, it's misleading and deprecated. More than likely
any user of Kerberos will prefer to do it through PAM.

Port maintainer (gnome@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-07-14 17:10:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-07-19 05:07:27 UTC
marcus      2008-07-19 04:07:19 UTC

  FreeBSD ports repository

  Modified files:
    x11/xscreensaver-gnome Makefile distinfo pkg-plist 
    x11/xscreensaver-gnome/files patch-driver_Makefile.in 
    x11/xscreensaver-gnome-hacks Makefile pkg-plist 
  Log:
  * Update to 5.06
  * Fix PAM support [1]
  
  PR:             125607 [1]
  Submitted by:   Marcin Wisnicki <mwisnicki+freebsd@gmail.com> [1]
  
  Revision  Changes    Path
  1.8       +1 -1      ports/x11/xscreensaver-gnome-hacks/Makefile
  1.5       +2 -0      ports/x11/xscreensaver-gnome-hacks/pkg-plist
  1.64      +3 -10     ports/x11/xscreensaver-gnome/Makefile
  1.24      +3 -3      ports/x11/xscreensaver-gnome/distinfo
  1.13      +3 -33     ports/x11/xscreensaver-gnome/files/patch-driver_Makefile.in
  1.27      +4 -0      ports/x11/xscreensaver-gnome/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2008-07-19 05:07:42 UTC
State Changed
From-To: open->closed

Committed, thanks!