building ports/games/xpuyopuyo fails when audio/libmikmod is installed. Fix: xpuyopuyo always try to use libmikmod even if WITHOUT_MIKMOD is set to 1. libmikmod-config returns "-pthread", and libtool in xpuyopuyo cannot treat it correctly. here is a patch: this patch can be stored as files/patch-ac. this is merely taken from recent libtool.--BDD2NrVIeuuTmh9fPNVZ0uuj4I2dl7uglWIrefRVhuH1ya74 Content-Type: text/plain; name="file.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="file.diff" --- ltmain.sh.orig 2008-07-26 17:06:14.000000000 +0900 +++ ltmain.sh 2008-07-26 17:06:24.000000000 +0900 @@ -1710,6 +1710,38 @@ lib= found=no case $deplib in + -mt|-mthreads|-kthread|-Kthread|-pthread|-pthreads|--thread-safe|-threads) + if test "$linkmode,$pass" = "prog,link"; then + compile_deplibs="$deplib $compile_deplibs" + finalize_deplibs="$deplib $finalize_deplibs" + else + compiler_flags="$compiler_flags $deplib" + fi + + case $linkmode in + lib) + deplibs="$deplib $deplibs" + test "$pass" = conv && continue + newdependency_libs="$deplib $newdependency_libs" + ;; + prog) + if test "$pass" = conv; then + deplibs="$deplib $deplibs" + continue + fi + if test "$pass" = scan; then + deplibs="$deplib $deplibs" + else + compile_deplibs="$deplib $compile_deplibs" + finalize_deplibs="$deplib $finalize_deplibs" + fi + ;; + *) + ;; + esac # linkmode + + continue + ;; -l*) if test $linkmode != lib && test $linkmode != prog; then $echo "$modename: warning: \`-l' is ignored for archives/objects" 1>&2 How-To-Repeat: % ls -d /var/db/pkg/libmikmod* libmikmod-esound-3.1.11_2 % cd /usr/ports/games/xpuyopuyo ... cc -DHAVE_CONFIG_H -I. -I. -I. -Ipgame -Ipai -Ipnet -O2 -fno-strict-aliasing -pipe -O2 -fno-strict-aliasing -pipe -Wall -Wpointer-arith -DMIKMOD=1 -DGTK=1 -DHAVE_GETOPT_H=1 -O2 -fno-strict-aliasing \ -pipe -Wall -Wpointer-arith -DMIKMOD=1 -DGTK=1 -DHAVE_GETOPT_H=1 -O2 -fno-strict-aliasing -pipe -Wall -Wpointer-arith -DMIKMOD=1 -DGTK=1 -DHAVE_GETOPT_H=1 -c xpuyopuyo.c /bin/sh ./libtool --mode=link cc -O2 -fno-strict-aliasing -pipe -O2 -fno-strict-aliasing -pipe -Wall -Wpointer-arith -DMIKMOD=1 -DGTK=1 -DHAVE_GETOPT_H=1 -O2 -fno-strict-aliasing -pipe -Wall \ -Wpointer-arith -DMIKMOD=1 -DGTK=1 -DHAVE_GETOPT_H=1 -O2 -fno-strict-aliasing -pipe -Wall -Wpointer-arith -DMIKMOD=1 -DGTK=1 -DHAVE_GETOPT_H=1 -o xpuyopuyo xpuyopuyo.o pgame/libxpp_game.a pai/libxpp_ai.a \ pgtk/libxpp_interface.a pnet/libxpp_net.a -L/usr/local/lib -lmikmod -pthread -L/usr/local/lib -lm psound/libxpp_sound.a -L/usr/local/lib -L/usr/local/lib -lgtk-12 -lgdk-12 -lgmodule-12 -lglib-12 \ -lintl -lXi -lXext -lX11 -lm pgame/libxpp_game.a putil/libxpp_util.a -lXpm -lX11 mkdir .libs libtool: link: cannot find the library `' ...
Maintainer of games/xpuyopuyo, Please note that PR ports/125974 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/125974 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
State Changed From-To: feedback->closed Duplicate of 125974
State Changed From-To: closed->feedback Closed the wrong one.
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
State Changed From-To: feedback->closed Committed. Thanks!
amdmi3 2008-09-04 00:50:08 UTC FreeBSD ports repository Added files: games/xpuyopuyo/files patch-ltmain.sh Log: - Fix build WITH_MIKMOD PR: 125974 Submitted by: Tsurutani Naoki <turutani at scphys dot kyoto-u dot ac dot jp> Approved by: maintainer timeout Revision Changes Path 1.1 +41 -0 ports/games/xpuyopuyo/files/patch-ltmain.sh (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"