Bug 126486 - [patch] devel/log4cxx fix compiling under FreeBSD 7
Summary: [patch] devel/log4cxx fix compiling under FreeBSD 7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-12 22:50 UTC by Volker
Modified: 2008-09-02 11:50 UTC (History)
0 users

See Also:


Attachments
file.diff (375 bytes, patch)
2008-08-12 22:50 UTC, Volker
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Volker 2008-08-12 22:50:00 UTC
devel/log4cxx does not compile under FreeBSD 7 (7.0-R, 7-STABLE):

 c++ -DHAVE_CONFIG_H -I. -I. -I../include/log4cxx -I../include -I/usr/local/include/libxml2 -I/usr/local/include -D_THREAD_SAFE -O2 -fno-strict-aliasing -pipe -c domconfigurator.cpp -MT domconfigurator.lo -MD -MP -MF .deps/domconfigurator.TPlo  -fPIC -DPIC -o .libs/domconfigurator.o
In file included from domconfigurator.cpp:29:
./include/log4cxx/xml/domconfigurator.h:211: error: extra qualification 'log4cxx::xml::DOMConfigurator::' on member 'subst'
*** Error code 1

Stop in /usr/ports/devel/log4cxx/work/log4cxx-0.9.7/src.
*** Error code 1

Stop in /usr/ports/devel/log4cxx/work/log4cxx-0.9.7.
*** Error code 1

Stop in /usr/ports/devel/log4cxx.

Fix: put the attached file info log4cxx/files (a one-liner patch)

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/devel/log4cxx; make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-12 22:50:10 UTC
Maintainer of devel/log4cxx,

Please note that PR ports/126486 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126486

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-12 22:50:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2008-09-01 16:11:50 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-09-02 11:49:30 UTC
amdmi3      2008-09-02 10:49:16 UTC

  FreeBSD ports repository

  Added files:
    devel/log4cxx/files  
                         patch-include-log4cxx-xml-domconfigurator.h 
  Log:
  - Fix compiling with gcc 4 in some cases
  
  PR:             126486
  Submitted by:   Volker Werth <volker at vwsoft dot com>
  Approved by:    maintainer timeout
  
  Revision  Changes    Path
  1.1       +14 -0     ports/devel/log4cxx/files/patch-include-log4cxx-xml-domconfigurator.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2008-09-02 11:50:38 UTC
State Changed
From-To: feedback->closed

Committed. Thanks! For the record: this port has multiple hidden 
dependencies which should be fixed. For example, the problem addressed 
in this PR only shows itself when libxml is installed.