Recent audio/last.fm update to version 1.3.2.14 has made the port unbuildable on amd64. build fails while compiling mp3transcode.cpp: mp3transcode.cpp:284: error: no matching function for call to 'qMin(int&, ssize_t)' For some (invalid) reason someone decided to cast int to ssize_t. Because on amd64 (and probably some other platforms) ssize_t is not the same as int, compiler lets you enjoy failed builds. Fix: In the same source file function qMin(int, int) is called four times so its safe to assume one more qMin(int, int) instead of qMin(int, ssize_t(int)) wont do anything bad. Other than that I found no problems with the source code. I'm not sure about the USE_GCC=4.2+ in makefile but it was there before, so I put it back. Patch attached with submission follows: How-To-Repeat: Try building audio/last.fm on amd64.
Responsible Changed From-To: freebsd-ports-bugs->miwi I'll take it.
State Changed From-To: open->closed Committed. Thanks!
miwi 2008-09-12 08:48:58 UTC FreeBSD ports repository Modified files: audio/last.fm Makefile Added files: audio/last.fm/files patch-src_mp3transcode_mp3transcode.cpp Log: - Fix build on amd64 PR: 127223 Submitted by: "Andrius Morkūnas" <hinokind@gmail.com> Approved by: portmgr (erwin) Revision Changes Path 1.19 +1 -1 ports/audio/last.fm/Makefile 1.1 +11 -0 ports/audio/last.fm/files/patch-src_mp3transcode_mp3transcode.cpp (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"