Bug 136284 - [patch] net-mgmt/p5-Cflow correct BUILD_DEPENDS
Summary: [patch] net-mgmt/p5-Cflow correct BUILD_DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-03 16:10 UTC by Frank Wall
Modified: 2009-07-05 23:10 UTC (History)
0 users

See Also:

Attachments
file.diff (359 bytes, patch)
2009-07-03 16:10 UTC, Frank Wall 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Wall 2009-07-03 16:10:01 UTC 
The port net-mgmt/p5-Cflow has the option WITH_FLOW_TOOLS.
This option depends on net-mgmt/flow-tools. When you try to build
net-mgmt/p5-Cflow with this option it will fail, if net-mgmt/flow-tools
was not installed before.

Fix: Add net-mgmt/flow-tools to BUILD_DEPENS:
BUILD_DEPENDS+=	${LOCALBASE}/lib/libft.a:${PORTSDIR}/net-mgmt/flow-tools

Patch attached with submission follows:
How-To-Repeat: 1. make sure net-mgmt/flow-tools is NOT installed

2. try to build net-mgmt/p5-Cflow:
   WITH_FLOW_TOOLS=1 make -C /usr/ports/net-mgmt/p5-Cflow

3. it fails complaining that ftlib.h from net-mgmt/flow-tools is missing:

===>  Building for p5-Cflow-1.053
cp Cflow.pm blib/lib/Cflow.pm
AutoSplitting blib/lib/Cflow.pm (blib/lib/auto/Cflow)
/usr/local/bin/perl5.8.9 /usr/local/lib/perl5/5.8.9/ExtUtils/xsubpp  -typemap /usr/local/lib/perl5/5.8.9/ExtUtils/typemap  Cflow.xs > Cflow.xsc && mv Cflow.xsc Cflow.c
cc -c  -I/usr/local/include  -O2 -fno-strict-aliasing -pipe -I/usr/local/include -DOSU -O2 -fno-strict-aliasing -pipe    -DVERSION=\"1.053\"  -DXS_VERSION=\"1.053\" -DPIC -fPIC "-I/usr/local/lib/perl5/5.8.9/mach/CORE"   Cflow.c
Cflow.xs:62:21: error: ftlib.h: No such file or directory
Cflow.xs: In function 'XS_Cflow_find':
Cflow.xs:575: error: storage size of 'fs' isn't known
Cflow.xs:580: error: storage size of 'ftv' isn't known
Cflow.xs:669: error: 'FT_IO_FLAG_READ' undeclared (first use in this function)
Cflow.xs:669: error: (Each undeclared identifier is reported only once
Cflow.xs:669: error: for each function it appears in.)
Cflow.xs:761: error: storage size of 'first' isn't known
Cflow.xs:761: error: storage size of 'last' isn't known
Cflow.xs:763: warning: assignment makes pointer from integer without a cast
Cflow.xs:767: error: dereferencing pointer to incomplete type
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2009-07-05 11:01:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2009-07-05 23:00:57 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2009-07-05 23:01:04 UTC 
miwi        2009-07-05 22:00:49 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/p5-Cflow    Makefile 
  Log:
  - Add missing dependency
  
  PR:             136284
  Submitted by:   Frank Wall <fw@moov.de>
  
  Revision  Changes    Path
  1.16      +2 -0      ports/net-mgmt/p5-Cflow/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"