Bug 147696 - [patch] powerpc64 support for security/nss
Summary: [patch] powerpc64 support for security/nss
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 20:10 UTC by Nathan Whitehorn
Modified: 2018-10-12 11:51 UTC (History)
0 users

See Also:

Attachments
nss-ppc64.diff (1.48 KB, patch)
2010-06-08 20:10 UTC, Nathan Whitehorn 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Whitehorn freebsd_committer freebsd_triage 2010-06-08 20:10:03 UTC 
security/nss fails to build on powerpc64, due to missing CPU_ARCH detection
and some G5-specific code in mpcpucache.c to detect cacheline sizes.

Fix: The attached patch adds CPU_ARCH logic for powerpc64 and uses a
FreeBSD-specific sysctl interface to detect cacheline sizes on PPC64 systems.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-08 20:10:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Koop Mast freebsd_committer freebsd_triage 2010-06-11 21:51:33 UTC 
State Changed
From-To: open->closed

Committed thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-06-11 21:51:44 UTC 
kwm         2010-06-11 20:51:24 UTC

  FreeBSD ports repository

  Modified files:
    security/nss/files   patch-..::coreconf::FreeBSD.mk 
  Added files:
    security/nss/files   patch-lib_freebl_mpi_mpcpucache.c 
  Log:
  Fix the build on powerpc64. By adding CPU_ARCH detection.
  And by adding some G5-specific code in mpcpucache.c to detect cacheline sizes.
  
  PR:             ports/147696
  Submitted by:   nwhitehorn@
  
  Revision  Changes    Path
  1.16      +5 -1      ports/security/nss/files/patch-..::coreconf::FreeBSD.mk
  1.1       +43 -0     ports/security/nss/files/patch-lib_freebl_mpi_mpcpucache.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-10-12 11:51:48 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Oct 12 11:50:45 UTC 2018
New revision: 481895
URL: https://svnweb.freebsd.org/changeset/ports/481895

Log:
  security/nss: unbreak on powerpc64 after r405494

  mpi/mpcpucache.c:728:23: error: incompatible pointer types passing 'int *' to parameter of type 'size_t *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]
              &cacheline_size, &clen, NULL, 0) < 0 || !cacheline_size)
                               ^~~~~
  /usr/include/sys/sysctl.h:1062:48: note: passing argument to parameter here
  int     sysctl(const int *, u_int, void *, size_t *, const void *, size_t);
                                                     ^
  PR:		147696 (typo origin)
  Reported by:	Mark Millard

Changes:
  head/security/nss/files/patch-lib_freebl_mpi_mpcpucache.c
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-10-12 11:51:50 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Oct 12 11:51:28 UTC 2018
New revision: 481896
URL: https://svnweb.freebsd.org/changeset/ports/481896

Log:
  MFH: r481895

  security/nss: unbreak on powerpc64 after r405494

  mpi/mpcpucache.c:728:23: error: incompatible pointer types passing 'int *' to parameter of type 'size_t *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]
              &cacheline_size, &clen, NULL, 0) < 0 || !cacheline_size)
                               ^~~~~
  /usr/include/sys/sysctl.h:1062:48: note: passing argument to parameter here
  int     sysctl(const int *, u_int, void *, size_t *, const void *, size_t);
                                                     ^
  PR:		147696 (typo origin)
  Reported by:	Mark Millard
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2018Q4/
  branches/2018Q4/security/nss/files/patch-lib_freebl_mpi_mpcpucache.c