- Update to 37 Added file(s): - files/patch-PythonCAD_Generic_preferences.py - files/patch-PythonCAD_Interface_Gtk_gtkimage.py Generated with FreeBSD Port Tools 0.99
Class Changed From-To: maintainer-update->change-request Fix category (submitter is not maintainer) (via the GNATS Auto Assign Tool)
Maintainer of cad/pythoncad, Please note that PR ports/149027 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/149027 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
On Wed, Jul 28, 2010 at 10:30:17AM +0000, Edwin Groothuis wrote: > Maintainer of cad/pythoncad, > > Please note that PR ports/149027 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. Yes I approve. Regards Sven Esbjerg
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
* Sven Esbjerg (esbjerg@xbsd.net) wrote: How about these changes in addition: * Use SF macro * Don't hardcode /usr/local * Clean up installation a bit * Use INSTALL_* macros * MKDIR unconditionally, it doesn't fail when dir exists * Use dirrmtry for etc dir, as it may contain user's prefs.py --- pythoncad.diff begins here --- diff -ruN pythoncad.orig/Makefile pythoncad/Makefile --- pythoncad.orig/Makefile 2010-08-24 04:32:25.000000000 +0400 +++ pythoncad/Makefile 2010-08-24 04:34:49.000000000 +0400 @@ -8,10 +8,8 @@ PORTNAME= pythoncad PORTVERSION= 37 -PORTREVISION= 1 CATEGORIES= cad -MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} -MASTER_SITE_SUBDIR= ${PORTNAME}/${PORTNAME}/R${PORTVERSION}/Source +MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/R${PORTVERSION}/Source DISTNAME= PythonCAD-DS1-R${PORTVERSION} MAINTAINER= fbsd-ports@xbsd.net @@ -27,12 +25,15 @@ PYDISTUTILS_PKGNAME= PythonCAD PYDISTUTILS_PKGVERSION= DS1-R${PORTVERSION} +post-patch: + @${REINPLACE_CMD} -e 's|/usr/local|${PREFIX}|' \ + ${WRKSRC}/PythonCAD/Generic/preferences.py \ + ${WRKSRC}/PythonCAD/Interface/Gtk/gtkimage.py + post-install: - ${INSTALL_SCRIPT} ${WRKSRC}/gtkpycad.py ${PREFIX}/bin/gtkpycad - ${CP} ${WRKSRC}/gtkpycad.png ${PREFIX}/share/pixmaps - @if [ ! -d ${PREFIX}/etc/pythoncad ] ; then \ - ${MKDIR} ${PREFIX}/etc/pythoncad ; \ - fi - ${CP} ${WRKSRC}/prefs.py ${PREFIX}/etc/pythoncad/prefs.py.sample + ${INSTALL_SCRIPT} ${WRKSRC}/gtkpycad.py ${PREFIX}/bin/gtkpycad + ${INSTALL_DATA} ${WRKSRC}/gtkpycad.png ${PREFIX}/share/pixmaps + ${MKDIR} ${PREFIX}/etc/pythoncad + ${INSTALL_DATA} ${WRKSRC}/prefs.py ${PREFIX}/etc/pythoncad/prefs.py.sample .include <bsd.port.mk> diff -ruN pythoncad.orig/pkg-plist pythoncad/pkg-plist --- pythoncad.orig/pkg-plist 2010-08-24 04:32:25.000000000 +0400 +++ pythoncad/pkg-plist 2010-08-20 07:03:17.000000000 +0400 @@ -303,4 +303,4 @@ @dirrm %%PYTHON_SITELIBDIR%%/PythonCAD/Interface @dirrm %%PYTHON_SITELIBDIR%%/PythonCAD/Generic @dirrm %%PYTHON_SITELIBDIR%%/PythonCAD -@dirrm etc/pythoncad +@dirrmtry etc/pythoncad --- pythoncad.diff ends here --- -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
State Changed From-To: open->feedback Ask for submitter approval.
On Tue, Aug 24, 2010 at 03:21:22PM +0400, Dmitry Marakasov wrote: > * Sven Esbjerg (fbsd-ports@xbsd.net) wrote: > > How about these changes in addition: > > * Use SF macro > * Don't hardcode /usr/local > * Clean up installation a bit > * Use INSTALL_* macros > * MKDIR unconditionally, it doesn't fail when dir exists > * Use dirrmtry for etc dir, as it may contain user's prefs.py Looks very good to me. I still need to learn the tricks ;) -Sven
State Changed From-To: feedback->closed Committed. Thanks!
amdmi3 2010-08-24 17:47:47 UTC FreeBSD ports repository Modified files: cad/pythoncad Makefile distinfo pkg-descr pkg-plist Added files: cad/pythoncad/files patch-PythonCAD_Generic_preferences.py patch-PythonCAD_Interface_Gtk_gtkimage.py Log: - Update to 37 PR: 149027 Submitted by: Sven Esbjerg <esbjerg@xbsd.net> (maintainer) Revision Changes Path 1.22 +13 -3 ports/cad/pythoncad/Makefile 1.11 +3 -3 ports/cad/pythoncad/distinfo 1.1 +11 -0 ports/cad/pythoncad/files/patch-PythonCAD_Generic_preferences.py (new) 1.1 +11 -0 ports/cad/pythoncad/files/patch-PythonCAD_Interface_Gtk_gtkimage.py (new) 1.2 +7 -4 ports/cad/pythoncad/pkg-descr 1.8 +264 -247 ports/cad/pythoncad/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"