Updated the port to the latest software release, reworked the old patches so as to hopefully make them transparent across plataforms (Linux and BSD). However, the Makefile patches (patch-aa & patch-ab) are not portable. I also added the .mo installation. The patches have been sent to the author but it is almost certain they won't be commited untill the next release, so ... The number of patch files has been maintained [aa-af].
> >Description: > Updated the port to the latest software release, reworked the old patches > so as to hopefully make them transparent across plataforms (Linux and BSD). > However, the Makefile patches (patch-aa & patch-ab) are not portable. I > also added the .mo installation. The patches have been sent to the author > but it is almost certain they won't be commited untill the next release, so ... > The number of patch files has been maintained [aa-af]. Did you already talk to the port's maintainer about the change? --- R. Imura
Dear Mr. Imura, ... > > also added the .mo installation. The patches have been sent to the author > > but it is almost certain they won't be commited untill the next release, so ... > Did you already talk to the port's maintainer about the change? I think there might have been a misundertanding. Where written author, read the distfile's author, not the port's author. My mistake. Anyway, I've already submitted twice the update to both authors, but none replied. Knowing that both authors' work is volunteer, I waited about 1 1/2 weeks for a any sort of reply. As none arrived, I considered appropriate the submition of a PR. I know that I could/should have waited more but the submition of the PR would give the port's author a pointer in case his unreachable state was due to a communication/network problem between our parts. If this is not due process, I apologize. If so, please advise me so that I won't commit the same mistake twice as I plan to contribute more actively in the future. I can insist with the author if you prefer but if you add the 1 1/2 weeks to the time this PR waited for processing, enough time elapsed for some sort of response. Regards, Mario Ferreira
Responsible Changed From-To: freebsd-ports->imura I'll take it. The following is a mail I sent to Mario. I forgot to Cc gnats. :-( --- OK. > As none arrived, I considered appropriate the submition of a > PR. I know that I could/should have waited more but the submition of the PR > would give the port's author a pointer in case his unreachable state was due to a communication/network problem between our parts. > If this is not due process, I apologize. If so, please advise me so > that I won't commit the same mistake twice as I plan to contribute more > actively in the future. > I can insist with the author if you prefer but if you add the 1 1/2 > weeks to the time this PR waited for processing, enough time elapsed for > some sort of response. Please write like "I waited ... days, but maintainer says nothing" next time, because we can't determine if we should commit. (It is too heavy work to let each maintainer know that we have such a PR of yours.) Some maintainer may feel bad if his port was changed out of his hands. :) Anyway, thanks for your great progress. I will commit your change.:)
State Changed From-To: open->closed Update committed, thanks!